Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any way pop log without sleeping? #85

Closed
imfht opened this issue Dec 4, 2020 · 4 comments
Closed

any way pop log without sleeping? #85

imfht opened this issue Dec 4, 2020 · 4 comments

Comments

@imfht
Copy link

imfht commented Dec 4, 2020

time.Sleep(time.Duration(rng.Intn(10)+1) * max / 10)

Thanks!

@vbauerster
Copy link
Owner

Sure, just remove it.

@imfht
Copy link
Author

imfht commented Dec 6, 2020

when the sleep removed.I get repeatly log.

code

package main

import (
	"fmt"
	"io"
	"math/rand"
	"sync"
	"time"

	"github.com/vbauerster/mpb/v5"
	"github.com/vbauerster/mpb/v5/decor"
)

func main() {
	p := mpb.New(mpb.PopCompletedMode())

	total, numBars := 100, 2
	for i := 0; i < numBars; i++ {
		name := fmt.Sprintf("Bar#%d:", i)
		bar := p.AddBar(int64(total),
			mpb.BarNoPop(),
			mpb.PrependDecorators(
				decor.Name(name),
				decor.Percentage(decor.WCSyncSpace),
			),
			mpb.AppendDecorators(
				decor.OnComplete(
					decor.EwmaETA(decor.ET_STYLE_GO, 60), "done!",
				),
			),
		)
		// simulating some work
		go func() {
			rng := rand.New(rand.NewSource(time.Now().UnixNano()))
			max := 100 * time.Millisecond
			for i := 0; i < total; i++ {
				// start variable is solely for EWMA calculation
				// EWMA's unit of measure is an iteration's duration
				start := time.Now()
				time.Sleep(time.Duration(rng.Intn(10)+1) * max / 10)
				bar.Increment()
				// we need to call DecoratorEwmaUpdate to fulfill ewma decorator's contract
				bar.DecoratorEwmaUpdate(time.Since(start))
			}
		}()
	}

	var wg sync.WaitGroup
	wg.Add(1)
	go func() {
		defer wg.Done()
		for i := 0; i < 10; i++ {
			filler := makeLogBar(fmt.Sprintf("some log: %d", i))
			p.Add(0, filler).SetTotal(0, true)
		}
	}()

	wg.Wait()
	p.Wait()
}

func makeLogBar(msg string) mpb.BarFiller {
	limit := "%%.%ds"
	return mpb.BarFillerFunc(func(w io.Writer, _ int, st decor.Statistics) {
		fmt.Fprintf(w, fmt.Sprintf(limit, st.AvailableWidth), msg)
	})
}

result

image

Coud you have a look?
Thanks!

vbauerster added a commit that referenced this issue Dec 6, 2020
@vbauerster
Copy link
Owner

vbauerster commented Dec 6, 2020

Thanks for picture, now I got what you meant. Can you please check out latest master 994c170?

@imfht
Copy link
Author

imfht commented Dec 7, 2020

thanks~ it works!

@imfht imfht closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants