Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(codeEditor): add type and config && add use case #3829

Merged
merged 4 commits into from
May 10, 2024
Merged

chore(codeEditor): add type and config && add use case #3829

merged 4 commits into from
May 10, 2024

Conversation

electroluxcode
Copy link

@electroluxcode electroluxcode commented May 10, 2024 •
edited
Loading

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

在保持原有代码行为的前提对codeEditor这个组件中做了以下几件事

  • 重命名: 原来的名字叫做 json 编辑器，但是codemirror并不止是json编辑器那么简单，更加适合的名称应该叫做代码编辑器
  • 增加类型: 原本的代码只支持JSON,JS,HTML三种类型，目前扩展到codemirror所支持的最大类型
  • 默认导入JSON,JS,HTML三种js改成按需动态导入
  • 增加在form中使用codeEditor组件的代码示例
  • 组件prop暴露config使得用户可以对codeEditor具体的配置项目进行配置

@wangjue666 wangjue666 merged commit 0ee7211 into vbenjs:main May 10, 2024
2 checks passed
@vbenjs vbenjs locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wangjue666 wangjue666 wangjue666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@electroluxcode @wangjue666