refactor/suggestions_to_refactor_code #17
+52
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArmCM
force-pushed
the
refactor/suggestions_to_refactor_code
branch
from
a60920a to
e25d744
Compare
ArmCM
commented
Sep 3, 2023
| def login(user: UserCreate): | ||
| validate_password(user) | ||
|
|
||
| token: str = create_token(user.dict()) |
There was a problem hiding this comment.
duda 🤔 , cual es el tipo de dato exacto que debe ser el token?
ya que aqui indicas que token debe ser de tipo string pero el método create_token retorna un dict.
y el IDE me marco un error, busque y me indica el dict esta deprecated para la versión 2 de pydantic
https://docs.pydantic.dev/latest/migration/#changes-to-pydanticbasemodel
pero desconozco si se hizo así por alguna razón .Aquí es a tu consideración bro
ArmCM
force-pushed
the
refactor/suggestions_to_refactor_code
branch
2 times, most recently
from
45a878d to
98a1edb
Compare
ArmCM
force-pushed
the
refactor/suggestions_to_refactor_code
branch
from
98a1edb to
ea2411b
Compare
ArmCM
force-pushed
the
refactor/suggestions_to_refactor_code
branch
from
f289db6 to
7630bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.