refactor!(cmd): Keyword-only params #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since libvcs is <1.0, lets clamp down on positional arguments until things are stable. Positional arguments are great, when there's a high degree of confidence in the first arg. We're not 100% on these as we're stubbing out endpoints rapidly at this juncture. See also: - https://docs.python.org/3.8/whatsnew/3.8.html#positional-only-parameters - https://peps.python.org/pep-0570/
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 70.26% 70.26%
=======================================
Files 21 21
Lines 1860 1860
=======================================
Hits 1307 1307
Misses 553 553
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libvcs is <1.0, lets clamp down on positional arguments
until things are stable. Positional arguments are great, when
there's a high degree of confidence in the first arg.
We're not 100% on these as we're stubbing out endpoints rapidly at this
juncture.
See also: https://docs.python.org/3.8/whatsnew/3.8.html#positional-only-parameters