Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: Enable pydocstyle w/ numpy convention #449

Merged
merged 47 commits into from Nov 26, 2023
Merged

ruff: Enable pydocstyle w/ numpy convention #449

merged 47 commits into from Nov 26, 2023

Conversation

tony
Copy link
Member

@tony tony commented Nov 25, 2023

@tony tony force-pushed the pydocstyle branch 4 times, most recently from bcbb91d to 28059d0 Compare November 26, 2023 13:15
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b47794) 62.61% compared to head (5953d2b) 62.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   62.61%   62.59%   -0.03%     
==========================================
  Files          39       39              
  Lines        3440     3438       -2     
  Branches      927      927              
==========================================
- Hits         2154     2152       -2     
  Misses        770      770              
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

`ruff --show-fixes --fix-only .`

Fixed 50 errors:
- src/libvcs/_internal/dataclasses.py:
     2 × D412 (blank-lines-between-header-and-content)
- src/libvcs/_internal/subprocess.py:
     1 × D412 (blank-lines-between-header-and-content)
- src/libvcs/_internal/types.py:
     1 × D412 (blank-lines-between-header-and-content)
- src/libvcs/cmd/git.py:
    13 × D403 (first-line-capitalized)
     1 × D202 (no-blank-line-after-function)
- src/libvcs/cmd/hg.py:
     1 × D202 (no-blank-line-after-function)
- src/libvcs/cmd/svn.py:
     1 × D202 (no-blank-line-after-function)
- src/libvcs/sync/base.py:
     1 × D202 (no-blank-line-after-function)
- src/libvcs/sync/git.py:
     2 × D202 (no-blank-line-after-function)
     1 × D412 (blank-lines-between-header-and-content)
- src/libvcs/sync/svn.py:
     1 × D202 (no-blank-line-after-function)
- src/libvcs/url/git.py:
     7 × D412 (blank-lines-between-header-and-content)
     1 × D405 (capitalize-section-name)
- src/libvcs/url/hg.py:
     7 × D412 (blank-lines-between-header-and-content)
     1 × D405 (capitalize-section-name)
- src/libvcs/url/svn.py:
     7 × D412 (blank-lines-between-header-and-content)
     1 × D405 (capitalize-section-name)
- tests/sync/test_git.py:
     1 × D403 (first-line-capitalized)

Fixed 50 errors (39 additional fixes available with `--unsafe-fixes`).
`ruff --show-fixes --fix-only --unsafe-fixes .`

Fixed 39 errors:
- conftest.py:
     1 × D400 (ends-in-period)
- docs/conf.py:
     1 × D400 (ends-in-period)
- src/libvcs/_internal/query_list.py:
     1 × D400 (ends-in-period)
- src/libvcs/_internal/subprocess.py:
     1 × D301 (escape-sequence-in-docstring)
- src/libvcs/_internal/types.py:
     1 × D400 (ends-in-period)
- src/libvcs/cmd/git.py:
    13 × D400 (ends-in-period)
- src/libvcs/cmd/hg.py:
     2 × D400 (ends-in-period)
- src/libvcs/cmd/svn.py:
     1 × D400 (ends-in-period)
- src/libvcs/pytest_plugin.py:
     3 × D400 (ends-in-period)
- src/libvcs/sync/git.py:
     3 × D400 (ends-in-period)
- src/libvcs/sync/svn.py:
     1 × D400 (ends-in-period)
- src/libvcs/url/base.py:
     2 × D400 (ends-in-period)
- src/libvcs/url/registry.py:
     1 × D400 (ends-in-period)
- tests/_internal/subprocess/test_SubprocessCommand.py:
     5 × D400 (ends-in-period)
- tests/url/test_git.py:
     1 × D400 (ends-in-period)
- tests/url/test_hg.py:
     1 × D400 (ends-in-period)
- tests/url/test_svn.py:
     1 × D400 (ends-in-period)

Fixed 39 errors.
@tony tony marked this pull request as ready for review November 26, 2023 13:42
@tony tony merged commit cb08169 into master Nov 26, 2023
7 checks passed
@tony tony deleted the pydocstyle branch November 26, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant