-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix indent and link #2501
fix indent and link #2501
Conversation
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
WalkthroughWalkthroughThe recent updates involve minor adjustments in two documentation files. In Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
[CHATOPS:HELP] ChatOps commands.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (8)
docs/tutorial/get-started.md (8)
Line range hint
15-15
: Add alt text to the image for accessibility.- <img src="../../assets/docs/tutorial/getstarted.svg" /> + <img src="../../assets/docs/tutorial/getstarted.svg" alt="Vald Architecture Overview" />
Line range hint
19-19
: Correct the case of anchor links to match their targets.- 1. [Check and Satisfy the Requirements](#Requirements) - 1. [Prepare Kubernetes Cluster](#Prepare-the-Kubernetes-Cluster) - 1. [Deploy Vald on Kubernetes Cluster](#Deploy-Vald-on-Kubernetes-Cluster) - 1. [Run Example Code](#Run-Example-Code) - 1. [Cleanup](#Cleanup) + 1. [Check and Satisfy the Requirements](#requirements) + 1. [Prepare Kubernetes Cluster](#prepare-the-kubernetes-cluster) + 1. [Deploy Vald on Kubernetes Cluster](#deploy-vald-on-kubernetes-cluster) + 1. [Run Example Code](#run-example-code) + 1. [Cleanup](#cleanup)Also applies to: 20-20, 21-21, 22-22, 23-23
Line range hint
30-30
: Improve grammatical structure for clarity.- libhdf5 (_only required for get started_) + libhdf5 (_only required to get started_)
Line range hint
65-65
: Enhance the expression for better clarity.- Please make sure these functions are available. + Please ensure these functions are enabled.
Line range hint
145-145
: Add missing possessive apostrophe for clarity.- you can check the Vald's pods status following command. + you can check the Vald's pods' status with the following command.
Line range hint
205-205
: Correct preposition for grammatical accuracy.- for requesting to Vald cluster. + for making requests to the Vald cluster.
Line range hint
317-317
: Simplify the expression for conciseness.- list of ids when loading is completed with success. + list of ids when loading is successfully completed.
Line range hint
463-463
: Elevate the tone for a more formal expression.- You completely entered the Vald World! + You have now fully entered the world of Vald!
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- docs/tutorial/get-started.md (1 hunks)
- docs/user-guides/read-replica-and-rotator.md (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/user-guides/read-replica-and-rotator.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
* fix links (#2500) Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> * fix indent and link (#2501) Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> * fix link (#2502) Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> * fix typo (#2503) * fix typo (#2504) * change fixed version to replace string (#2506) * change fixed version to replace string Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> * Update docs/overview/component/agent.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com> --------- Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com> Co-authored-by: Kosuke Morimoto <ksk@vdaas.org> Co-authored-by: datelier <57349093+datelier@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit