create internal/worker/queue test #606

vankichi · 2020-07-31T06:55:01Z

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

There are 2 changes:

create test of internal/worker/queue.
update comments for each function of internal/worker/queue
And 1 bug fix:
add close(ech) in func(q) Starts() (<-chan error, error)

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-07-31T06:55:08Z

Best reviewed: commit by commit

Optimal code review plan (3 warnings)

✅ create internal/worker/queue test

internal/worker/queue.go 50% changes removed in ✅ f...

✅ add comment

internal/worker/queue.go 71% changes removed in ✅ f...

✅ fix

✅ fix spell

✅ fix

internal/worker/queue_test.go 50% changes removed in ✅ f...

✅ fix

Powered by Pull Assistant. Last update 8f0b058 ... 88b3e49. Read the comment docs.

vdaas-ci · 2020-07-31T06:55:25Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

internal/worker/queue.go

internal/worker/queue_test.go

codecov · 2020-07-31T07:03:05Z

Codecov Report

Merging #606 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
+ Coverage   12.19%   12.57%   +0.38%     
==========================================
  Files         409      409              
  Lines       21340    21341       +1     
==========================================
+ Hits         2602     2684      +82     
+ Misses      18454    18375      -79     
+ Partials      284      282       -2

Impacted Files	Coverage Δ
internal/worker/queue.go	`98.55% <100.00%> (+98.55%)`	⬆️
internal/worker/queue_option.go	`89.47% <0.00%> (+73.68%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd5fc9...88b3e49. Read the comment docs.

internal/worker/queue_test.go

internal/worker/queue.go

internal/worker/queue_test.go

internal/worker/queue.go

internal/worker/queue_test.go

hlts2

LGTM

kevindiu

LGTM

vankichi · 2020-08-05T06:52:17Z

/rebase
/format
/approve

vdaas-ci · 2020-08-05T06:52:52Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/worker_queue_test

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci · 2020-08-05T06:53:52Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

Signed-off-by: vankichi <kyukawa315@gmail.com>

kevindiu

LGTM

hlts2

LGTM

vankichi · 2020-08-06T01:04:25Z

/rebase
/format
/approve

vdaas-ci · 2020-08-06T01:05:01Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/worker_queue_test

vdaas-ci · 2020-08-06T01:06:31Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests priority/low labels Jul 31, 2020

github-actions bot reviewed Jul 31, 2020

View reviewed changes

internal/worker/queue.go Outdated Show resolved Hide resolved

internal/worker/queue_test.go Outdated Show resolved Hide resolved

internal/worker/queue_test.go Outdated Show resolved Hide resolved

internal/worker/queue_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Jul 31, 2020

View reviewed changes

internal/worker/queue_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Jul 31, 2020

View reviewed changes

internal/worker/queue_test.go Show resolved Hide resolved

internal/worker/queue_test.go Outdated Show resolved Hide resolved

internal/worker/queue_test.go Outdated Show resolved Hide resolved

vankichi changed the title ~~[WIP] create internal/worker/queue test~~ create internal/worker/queue test Aug 3, 2020

vankichi marked this pull request as ready for review August 3, 2020 05:57

vankichi requested review from hlts2 and kevindiu August 3, 2020 05:57

kevindiu reviewed Aug 3, 2020

View reviewed changes

hlts2 reviewed Aug 4, 2020

View reviewed changes

internal/worker/queue_test.go Outdated Show resolved Hide resolved

hlts2 reviewed Aug 4, 2020

View reviewed changes

internal/worker/queue_test.go Outdated Show resolved Hide resolved

hlts2 reviewed Aug 4, 2020

View reviewed changes

internal/worker/queue_test.go Outdated Show resolved Hide resolved

hlts2 requested changes Aug 4, 2020

View reviewed changes

vankichi mentioned this pull request Aug 4, 2020

Add internal/worker/worker test #602

Merged

18 tasks

hlts2 reviewed Aug 5, 2020

View reviewed changes

internal/worker/queue_test.go Show resolved Hide resolved

hlts2 reviewed Aug 5, 2020

View reviewed changes

internal/worker/queue_test.go Outdated Show resolved Hide resolved

kevindiu reviewed Aug 5, 2020

View reviewed changes

internal/worker/queue.go Outdated Show resolved Hide resolved

kevindiu reviewed Aug 5, 2020

View reviewed changes

internal/worker/queue_test.go Outdated Show resolved Hide resolved

hlts2 previously approved these changes Aug 5, 2020

View reviewed changes

kevindiu previously approved these changes Aug 5, 2020

View reviewed changes

✅ create internal/worker/queue test

8f0b058

Signed-off-by: vankichi <kyukawa315@gmail.com>

vankichi added 8 commits August 5, 2020 06:52

✅ add comment

d2b9bbc

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

dded029

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix spell

0aec7f5

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

0f975e3

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

7b9f25e

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

94eaa7d

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

ab28116

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

cb4ac24

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci dismissed stale reviews from kevindiu and hlts2 via cb4ac24 August 5, 2020 06:53

vdaas-ci force-pushed the test/internal/worker_queue_test branch from 853310c to cb4ac24 Compare August 5, 2020 06:53

vdaas-ci previously approved these changes Aug 5, 2020

View reviewed changes

✅ fix

88b3e49

Signed-off-by: vankichi <kyukawa315@gmail.com>

vankichi dismissed vdaas-ci’s stale review via 88b3e49 August 5, 2020 09:26

kevindiu approved these changes Aug 5, 2020

View reviewed changes

hlts2 approved these changes Aug 5, 2020

View reviewed changes

vdaas-ci approved these changes Aug 6, 2020

View reviewed changes

vankichi merged commit 5698abc into master Aug 6, 2020

vankichi deleted the test/internal/worker_queue_test branch August 6, 2020 01:08

vdaas-ci mentioned this pull request Sep 2, 2020

[patch] update deps #660

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create internal/worker/queue test #606

create internal/worker/queue test #606

vankichi commented Jul 31, 2020 •

edited

Loading

pull-assistant bot commented Jul 31, 2020 •

edited

Loading

vdaas-ci commented Jul 31, 2020

codecov bot commented Jul 31, 2020 •

edited

Loading

hlts2 left a comment

kevindiu left a comment

vankichi commented Aug 5, 2020

vdaas-ci commented Aug 5, 2020

vdaas-ci commented Aug 5, 2020

vdaas-ci left a comment

kevindiu left a comment

hlts2 left a comment

vankichi commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci left a comment

create internal/worker/queue test #606

create internal/worker/queue test #606

Conversation

vankichi commented Jul 31, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jul 31, 2020 • edited Loading

vdaas-ci commented Jul 31, 2020

codecov bot commented Jul 31, 2020 • edited Loading

Codecov Report

hlts2 left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi commented Aug 5, 2020

vdaas-ci commented Aug 5, 2020

vdaas-ci commented Aug 5, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

vankichi commented Jul 31, 2020 •

edited

Loading

pull-assistant bot commented Jul 31, 2020 •

edited

Loading

codecov bot commented Jul 31, 2020 •

edited

Loading