Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vrl): update unquoted allowed-characters #14114

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

JeanMertz
Copy link
Contributor

fixes #13461.

@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 35ba8de
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/630cc048cbfad700080a29e7
😎 Deploy Preview https://deploy-preview-14114--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: vrl Anything related to the Vector Remap Language label Aug 26, 2022
@jszwedko jszwedko added this to the Vector v0.24.0 milestone Aug 26, 2022
@@ -0,0 +1,8 @@
# result: true

.@foo = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each line should be a separate test here. The panic is an underflow of the source code, so only the first one will actually panic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 working on an update to this PR.

@github-actions
Copy link

Soak Test Results

Baseline: deea758
Comparison: 91d1d32
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_pipelines_blackhole_acks 13.22KiB 1.07 100.00% 1.21MiB 110.83KiB 2.26KiB 0 0.0897074 1.22MiB 64.59KiB 1.32KiB 0 0.0517219 False False
datadog_agent_remap_blackhole_acks 472.49KiB 0.81 95.58% 57.26MiB 8.27MiB 172.21KiB 0 0.144385 57.73MiB 7.63MiB 159.53KiB 0 0.132102 False False
splunk_hec_route_s3 109.08KiB 0.57 89.87% 18.8MiB 2.31MiB 48.06KiB 0 0.122713 18.91MiB 2.2MiB 46.04KiB 0 0.116355 False False
syslog_splunk_hec_logs 46.08KiB 0.28 98.43% 16.32MiB 734.57KiB 14.95KiB 0 0.0439478 16.36MiB 579.26KiB 11.83KiB 0 0.0345609 False False
http_pipelines_no_grok_blackhole 20.59KiB 0.18 64.90% 10.99MiB 346.2KiB 7.07KiB 0 0.0307479 11.01MiB 1.0MiB 20.91KiB 0 0.0911024 False False
datadog_agent_remap_blackhole 71.16KiB 0.11 40.88% 61.86MiB 4.89MiB 101.88KiB 0 0.0789573 61.93MiB 4.06MiB 84.69KiB 0 0.0655183 False False
splunk_hec_to_splunk_hec_logs_noack 17.55KiB 0.07 86.35% 23.82MiB 472.94KiB 9.66KiB 0 0.0193849 23.84MiB 330.71KiB 6.75KiB 0 0.0135454 False False
enterprise_http_to_http -520.39B -0 5.54% 23.85MiB 256.98KiB 5.25KiB 0 0.0105219 23.85MiB 248.96KiB 5.09KiB 0 0.0101936 False False
syslog_log2metric_splunk_hec_metrics -412.91B -0 1.50% 17.89MiB 662.3KiB 13.49KiB 0 0.0361545 17.89MiB 818.75KiB 16.65KiB 0 0.0446956 False False
splunk_hec_to_splunk_hec_logs_acks -6.82KiB -0.03 22.38% 23.76MiB 818.44KiB 16.65KiB 0 0.0336316 23.75MiB 849.23KiB 17.27KiB 0 0.0349066 False False
splunk_hec_indexer_ack_blackhole -11.58KiB -0.05 33.78% 23.75MiB 898.47KiB 18.28KiB 0 0.0369326 23.74MiB 944.16KiB 19.2KiB 0 0.0388293 False False
file_to_blackhole -57.38KiB -0.06 43.78% 95.34MiB 3.13MiB 64.99KiB 0 0.0328749 95.28MiB 3.59MiB 74.68KiB 0 0.037693 False False
http_to_http_json -24.38KiB -0.1 95.45% 23.84MiB 359.89KiB 7.35KiB 0 0.0147367 23.82MiB 475.58KiB 9.72KiB 0 0.0194934 False False
syslog_humio_logs -22.56KiB -0.13 100.00% 16.55MiB 155.32KiB 3.17KiB 0 0.00916475 16.53MiB 140.18KiB 2.87KiB 0 0.00828223 False False
socket_to_socket_blackhole -39.76KiB -0.16 100.00% 23.57MiB 150.17KiB 3.07KiB 0 0.00622111 23.53MiB 183.27KiB 3.74KiB 0 0.00760492 False False
syslog_loki -34.81KiB -0.23 96.17% 14.69MiB 390.99KiB 8.0KiB 0 0.0259866 14.66MiB 726.45KiB 14.77KiB 0 0.0483942 False False
syslog_regex_logs2metric_ddmetrics -30.48KiB -0.24 91.77% 12.66MiB 566.68KiB 11.55KiB 0 0.0436974 12.63MiB 648.19KiB 13.2KiB 0 0.0501002 False False
http_to_http_noack -60.98KiB -0.25 99.25% 23.83MiB 512.87KiB 10.48KiB 0 0.0210144 23.77MiB 992.42KiB 20.22KiB 0 0.0407656 False False
datadog_agent_remap_datadog_logs_acks -182.74KiB -0.29 87.25% 62.16MiB 3.49MiB 72.89KiB 0 0.056111 61.98MiB 4.57MiB 95.16KiB 0 0.0737434 False False
http_pipelines_blackhole -5.47KiB -0.33 98.37% 1.6MiB 34.68KiB 725.52B 0 0.0211425 1.6MiB 106.16KiB 2.16KiB 0 0.0649323 False False
syslog_log2metric_humio_metrics -44.65KiB -0.33 99.98% 13.07MiB 282.3KiB 5.76KiB 0 0.0210822 13.03MiB 512.74KiB 10.44KiB 0 0.0384193 False False
fluent_elasticsearch -462.96KiB -0.57 100.00% 79.47MiB 54.46KiB 1.1KiB 0 0.000669124 79.02MiB 4.51MiB 92.53KiB 0 0.0570256 False False
datadog_agent_remap_datadog_logs -443.82KiB -0.7 99.99% 61.78MiB 2.22MiB 46.53KiB 0 0.0359147 61.35MiB 4.77MiB 99.36KiB 0 0.0777752 False False
http_text_to_http_json -571.07KiB -1.36 100.00% 41.04MiB 840.51KiB 17.16KiB 0 0.0199967 40.48MiB 1.37MiB 28.55KiB 0 0.0337308 False False
http_to_http_acks -273.33KiB -1.53 76.65% 17.43MiB 7.79MiB 162.77KiB 0 0.446572 17.17MiB 7.74MiB 161.62KiB 0 0.450493 True True

@JeanMertz JeanMertz force-pushed the jean/13461-vrl-coalesce-assignment-panic branch from 91d1d32 to 12cfffe Compare August 26, 2022 17:53
@jszwedko jszwedko requested a review from fuchsnj August 26, 2022 17:57
Copy link
Member

@fuchsnj fuchsnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a failing test from allowing @ in the regex, but overall this is fine.

@github-actions
Copy link

Soak Test Results

Baseline: 573b309
Comparison: 12cfffe
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

Changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

experiment Δ mean Δ mean % confidence
http_text_to_http_json 4.21MiB 11.41 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_text_to_http_json 4.21MiB 11.41 100.00% 36.94MiB 797.66KiB 16.28KiB 0 0.02108 41.16MiB 720.57KiB 14.71KiB 0 0.0170929 False False
socket_to_socket_blackhole 1.09MiB 4.87 100.00% 22.28MiB 255.79KiB 5.22KiB 0 0.0112083 23.37MiB 365.68KiB 7.47KiB 0 0.0152792 False False
syslog_loki 502.45KiB 3.44 100.00% 14.27MiB 312.96KiB 6.41KiB 0 0.0214093 14.76MiB 731.43KiB 14.87KiB 0 0.0483738 False False
http_to_http_acks 363.14KiB 2.08 88.35% 17.03MiB 7.81MiB 163.24KiB 0 0.458399 17.38MiB 7.85MiB 163.91KiB 0 0.451751 True True
datadog_agent_remap_datadog_logs 1.08MiB 1.74 100.00% 61.71MiB 337.17KiB 6.91KiB 0 0.00533417 62.79MiB 4.43MiB 92.26KiB 0 0.0705749 False False
datadog_agent_remap_blackhole_acks 792.54KiB 1.3 100.00% 59.44MiB 4.18MiB 86.99KiB 0 0.0702715 60.22MiB 2.69MiB 56.32KiB 0 0.0446738 False False
datadog_agent_remap_datadog_logs_acks 730.98KiB 1.2 100.00% 59.25MiB 4.29MiB 89.72KiB 0 0.0724345 59.96MiB 5.45MiB 113.42KiB 0 0.090856 False False
http_pipelines_blackhole_acks 10.66KiB 0.86 100.00% 1.21MiB 103.5KiB 2.11KiB 0 0.0832869 1.22MiB 70.26KiB 1.43KiB 0 0.0560599 False False
syslog_log2metric_humio_metrics 89.3KiB 0.67 100.00% 12.93MiB 189.35KiB 3.87KiB 0 0.0142993 13.02MiB 450.58KiB 9.18KiB 0 0.0337998 False False
datadog_agent_remap_blackhole 363.61KiB 0.56 99.85% 62.96MiB 4.17MiB 86.9KiB 0 0.0662263 63.32MiB 3.59MiB 74.82KiB 0 0.0566614 False False
splunk_hec_route_s3 50.29KiB 0.28 46.49% 17.65MiB 2.76MiB 57.54KiB 0 0.156385 17.7MiB 2.73MiB 57.1KiB 0 0.154152 False False
splunk_hec_to_splunk_hec_logs_noack 9.73KiB 0.04 62.87% 23.83MiB 418.98KiB 8.55KiB 0 0.0171673 23.84MiB 329.3KiB 6.72KiB 0 0.0134873 False False
enterprise_http_to_http -1.73KiB -0.01 19.16% 23.85MiB 245.55KiB 5.01KiB 0 0.0100537 23.85MiB 247.6KiB 5.07KiB 0 0.0101383 False False
splunk_hec_to_splunk_hec_logs_acks -3.33KiB -0.01 11.27% 23.76MiB 815.08KiB 16.59KiB 0 0.0334908 23.76MiB 817.77KiB 16.64KiB 0 0.0336057 False False
syslog_splunk_hec_logs -2.46KiB -0.01 9.81% 16.32MiB 769.5KiB 15.66KiB 0 0.0460284 16.32MiB 605.72KiB 12.36KiB 0 0.036237 False False
splunk_hec_indexer_ack_blackhole -18.62KiB -0.08 50.91% 23.75MiB 904.09KiB 18.39KiB 0 0.0371636 23.73MiB 974.22KiB 19.81KiB 0 0.0400773 False False
file_to_blackhole -96.51KiB -0.1 75.81% 95.38MiB 2.82MiB 58.38KiB 0 0.02952 95.28MiB 2.8MiB 58.24KiB 0 0.0294141 False False
http_to_http_json -34.65KiB -0.14 99.44% 23.85MiB 328.83KiB 6.71KiB 0 0.0134631 23.81MiB 516.23KiB 10.55KiB 0 0.0211659 False False
fluent_elasticsearch -203.54KiB -0.25 100.00% 79.47MiB 53.08KiB 1.07KiB 0 0.000652095 79.27MiB 1.75MiB 35.92KiB 0 0.0220174 False False
http_to_http_noack -104.83KiB -0.43 100.00% 23.84MiB 409.48KiB 8.37KiB 0 0.0167723 23.73MiB 1.15MiB 24.01KiB 0 0.0485162 False False
http_pipelines_blackhole -9.54KiB -0.55 99.96% 1.69MiB 11.51KiB 240.91B 0 0.00663567 1.68MiB 130.51KiB 2.66KiB 0 0.0756329 False False
syslog_regex_logs2metric_ddmetrics -85.42KiB -0.66 100.00% 12.68MiB 508.94KiB 10.38KiB 0 0.0391888 12.6MiB 566.63KiB 11.55KiB 0 0.0439204 False False
http_pipelines_no_grok_blackhole -101.45KiB -0.9 100.00% 11.01MiB 87.95KiB 1.8KiB 0 0.00780119 10.91MiB 1.09MiB 22.59KiB 0 0.0994578 False False
syslog_humio_logs -436.87KiB -2.73 100.00% 15.65MiB 1.29MiB 26.88KiB 0 0.0821243 15.23MiB 1.41MiB 29.59KiB 0 0.0926315 False False
syslog_log2metric_splunk_hec_metrics -520.81KiB -2.92 100.00% 17.4MiB 969.27KiB 19.76KiB 0 0.054381 16.89MiB 1.19MiB 24.87KiB 0 0.0706485 False False

Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
@JeanMertz JeanMertz force-pushed the jean/13461-vrl-coalesce-assignment-panic branch from 12cfffe to 35ba8de Compare August 29, 2022 13:33
@github-actions
Copy link

Soak Test Results

Baseline: 36ea6cb
Comparison: 35ba8de
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_pipelines_blackhole_acks 10.24KiB 0.82 99.99% 1.21MiB 110.56KiB 2.25KiB 0 0.0888685 1.22MiB 66.37KiB 1.35KiB 0 0.0529173 False False
datadog_agent_remap_blackhole 500.42KiB 0.78 100.00% 62.92MiB 4.5MiB 93.63KiB 0 0.0714729 63.41MiB 2.51MiB 52.37KiB 0 0.0395564 False False
socket_to_socket_blackhole 166.21KiB 0.69 100.00% 23.43MiB 687.36KiB 14.03KiB 0 0.0286425 23.59MiB 361.5KiB 7.38KiB 0 0.0149601 False False
datadog_agent_remap_blackhole_acks 397.83KiB 0.61 100.00% 64.15MiB 4.33MiB 90.08KiB 0 0.0674248 64.53MiB 1.53MiB 32.09KiB 0 0.023714 False False
splunk_hec_route_s3 94.41KiB 0.49 84.63% 18.69MiB 2.31MiB 47.99KiB 0 0.12333 18.78MiB 2.18MiB 45.55KiB 0 0.115838 False False
syslog_splunk_hec_logs 38.75KiB 0.23 97.51% 16.58MiB 667.69KiB 13.6KiB 0 0.0393099 16.62MiB 521.29KiB 10.63KiB 0 0.0306209 False False
splunk_hec_to_splunk_hec_logs_noack 14.7KiB 0.06 79.29% 23.82MiB 460.51KiB 9.4KiB 0 0.0188737 23.84MiB 336.99KiB 6.88KiB 0 0.0138033 False False
splunk_hec_indexer_ack_blackhole 13.06KiB 0.05 40.54% 23.75MiB 872.51KiB 17.74KiB 0 0.0358714 23.76MiB 832.51KiB 16.94KiB 0 0.0342084 False False
splunk_hec_to_splunk_hec_logs_acks 7.89KiB 0.03 25.41% 23.75MiB 867.91KiB 17.65KiB 0 0.0356796 23.76MiB 823.68KiB 16.76KiB 0 0.0338503 False False
syslog_regex_logs2metric_ddmetrics 1.04KiB 0.01 2.53% 11.83MiB 1.11MiB 23.12KiB 0 0.0936322 11.83MiB 1.12MiB 23.39KiB 0 0.094708 False False
syslog_humio_logs 221.32B 0 2.00% 15.91MiB 297.33KiB 6.07KiB 0 0.0182491 15.91MiB 297.75KiB 6.1KiB 0 0.0182747 False False
enterprise_http_to_http -1.8KiB -0.01 19.74% 23.85MiB 244.28KiB 4.99KiB 0 0.0100015 23.85MiB 253.39KiB 5.18KiB 0 0.0103753 False False
file_to_blackhole -62.77KiB -0.06 42.89% 95.34MiB 3.54MiB 73.37KiB 0 0.037117 95.27MiB 4.0MiB 83.03KiB 0 0.0419255 False False
syslog_loki -11.57KiB -0.08 47.79% 14.38MiB 455.37KiB 9.32KiB 0 0.0309132 14.37MiB 762.1KiB 15.49KiB 0 0.0517769 False False
http_to_http_acks -13.77KiB -0.08 4.65% 17.46MiB 8.05MiB 168.33KiB 0 0.461006 17.44MiB 7.92MiB 165.32KiB 0 0.453949 True True
http_to_http_json -42.22KiB -0.17 99.87% 23.85MiB 330.22KiB 6.74KiB 0 0.01352 23.81MiB 552.35KiB 11.27KiB 0 0.022654 False False
fluent_elasticsearch -154.74KiB -0.19 100.00% 79.47MiB 54.73KiB 1.11KiB 0 0.000672356 79.32MiB 1.42MiB 29.25KiB 0 0.0179138 False False
datadog_agent_remap_datadog_logs_acks -142.13KiB -0.22 77.64% 62.39MiB 3.44MiB 71.78KiB 0 0.0550762 62.25MiB 4.43MiB 92.12KiB 0 0.0710772 False False
syslog_log2metric_humio_metrics -33.76KiB -0.25 99.69% 13.0MiB 137.08KiB 2.8KiB 0 0.0102957 12.97MiB 542.57KiB 11.04KiB 0 0.0408556 False False
syslog_log2metric_splunk_hec_metrics -56.47KiB -0.31 98.68% 17.7MiB 708.76KiB 14.44KiB 0 0.0390977 17.64MiB 866.04KiB 17.62KiB 0 0.0479229 False False
http_text_to_http_json -167.05KiB -0.43 100.00% 38.15MiB 1.09MiB 22.83KiB 0 0.0286319 37.98MiB 1.32MiB 27.51KiB 0 0.034635 False False
http_pipelines_blackhole -7.51KiB -0.45 98.90% 1.64MiB 71.07KiB 1.45KiB 0 0.0423329 1.63MiB 126.06KiB 2.57KiB 0 0.0754221 False False
datadog_agent_remap_datadog_logs -328.22KiB -0.51 99.97% 62.64MiB 1.07MiB 22.33KiB 0 0.016999 62.32MiB 4.19MiB 87.36KiB 0 0.0672989 False False
http_to_http_noack -126.95KiB -0.52 100.00% 23.84MiB 401.37KiB 8.21KiB 0 0.0164408 23.71MiB 1.24MiB 25.92KiB 0 0.0524503 False False
http_pipelines_no_grok_blackhole -116.39KiB -1.02 100.00% 11.11MiB 45.26KiB 946.42B 0 0.00397642 11.0MiB 1.03MiB 21.52KiB 0 0.0939345 False False

@JeanMertz JeanMertz merged commit 9b73df3 into master Aug 29, 2022
@JeanMertz JeanMertz deleted the jean/13461-vrl-coalesce-assignment-panic branch August 29, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vrl Anything related to the Vector Remap Language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VRL coalesce assignment panics
4 participants