Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(healthchecks): instrument healthchecks with component span #20411

Closed
wants to merge 3 commits into from

Conversation

StephenWakely
Copy link
Contributor

Fixes #20356

This instruments the healthcheck task with the sink component span.

The aws s3 sink healthcheck sends a request to check the bucket can be written to. During the AWS upgrade a wrapper over the http connection was created that could instrument the bytes sent. Since the healthcheck was not being instrumented this resulted in an empty component_sent_bytes_total being emitted.

I am quite surprised that this error hasn't cropped up sooner, so it is well worth double checking that I am fixing this the correct way.

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
@StephenWakely StephenWakely requested a review from a team as a code owner May 1, 2024 12:47
@github-actions github-actions bot added the domain: topology Anything related to Vector's topology code label May 1, 2024
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented May 1, 2024

Datadog Report

Branch report: stephen/instrument_healthchecks
Commit report: 9c07ae3
Test service: vector

✅ 0 Failed, 87 Passed, 0 Skipped, 4m 31.58s Wall Time

Copy link
Contributor

@neuronull neuronull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: sinks Anything related to the Vector's sinks and removed domain: topology Anything related to Vector's topology code labels May 3, 2024
@StephenWakely
Copy link
Contributor Author

Pushed code to use a flag to not emit. Still need to -

  • Update PR title to more accurately describe what it's doing
  • Check all the AWS components to ensure they all do this.

Moving to draft until I do those..

@StephenWakely StephenWakely marked this pull request as draft May 3, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty component_sent_bytes_total but not in component_sent_event_bytes_total
2 participants