fix(healthchecks): instrument healthchecks with component span #20411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20356
This instruments the healthcheck task with the sink component span.
The aws s3 sink healthcheck sends a request to check the bucket can be written to. During the AWS upgrade a wrapper over the http connection was created that could instrument the bytes sent. Since the healthcheck was not being instrumented this resulted in an empty
component_sent_bytes_total
being emitted.I am quite surprised that this error hasn't cropped up sooner, so it is well worth double checking that I am fixing this the correct way.