You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Request: permission to open a PR for a Hermes integration fix (unclosed aiohttp session after shutdown)
#5717
I know CONTRIBUTING.md says external PRs are not accepted, so I'm asking first instead of opening one.
I found and fixed a bug in hindsight-integrations/hermes: after shutdown() the plugin can still create a new client, and the close is not done under the lock, which leaves an "Unclosed client session" warning (aiohttp). The fix is ready and tested (integration test suite: 142 passed), based on main @ 5331da2:
Would you be willing to accept it as a PR (or grant permission to open one)? If you prefer, I can instead file it as a bug report with a repro and you take the fix from the branch.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Hi Hindsight team,
I know CONTRIBUTING.md says external PRs are not accepted, so I'm asking first instead of opening one.
I found and fixed a bug in hindsight-integrations/hermes: after shutdown() the plugin can still create a new client, and the close is not done under the lock, which leaves an "Unclosed client session" warning (aiohttp). The fix is ready and tested (integration test suite: 142 passed), based on main @ 5331da2:
https://github.com/XLakarX/hindsight/tree/fix/hermes-client-closed-after-shutdown
(commit 193cdf3)
Would you be willing to accept it as a PR (or grant permission to open one)? If you prefer, I can instead file it as a bug report with a repro and you take the fix from the branch.
Thanks!
All reactions