Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent column sort when hitting Enter in filter #233

Closed
gesior opened this issue Sep 8, 2015 · 4 comments
Closed

Prevent column sort when hitting Enter in filter #233

gesior opened this issue Sep 8, 2015 · 4 comments
Labels

Comments

@gesior
Copy link

gesior commented Sep 8, 2015

When I type something in 'filter', it works fine.
When I click enter with 'focus' on filter element, it sort data by column in which is filter.

Can I disable it somehow? Any on/off option in config?

Many people that use old programs click 'enter' after they type text they want to search (not expect 'live' updates).

@vedmack
Copy link
Owner

vedmack commented Sep 8, 2015

You are right, haven't noticed it before... will disable pressing enter on filter since there is no point in them.

@vedmack vedmack added the bug label Sep 8, 2015
@gesior gesior changed the title Number/text filter, sort by column 'on enter' Number range/text filter, sort by column 'on enter' Sep 8, 2015
@gesior gesior changed the title Number range/text filter, sort by column 'on enter' Number range[min-max]/text filter, sort by column 'on enter' Sep 8, 2015
@gesior
Copy link
Author

gesior commented Sep 8, 2015

'Number range' from this example:

http://yadcf-showcase.appspot.com/DOM_source_chosen.html

I don't know, if it's a bug, but this filter is called:
range_number_slider

There is no slider, just 2 input fields for min/max value.

@vedmack
Copy link
Owner

vedmack commented Sep 8, 2015

@gesior , on that showcase (see js source file] I'm using filter_type: "range_number" , the code snippet that is shown in the bottom is indeed wrong... will update the showcase next time a new beta will be released.

@vedmack vedmack changed the title Number range[min-max]/text filter, sort by column 'on enter' Prevent column sort when hitting Enter in filter Oct 2, 2015
@vedmack
Copy link
Owner

vedmack commented Oct 2, 2015

fixed in 0.8.9.beta.20

@vedmack vedmack closed this as completed Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants