Add SM/USUM pokedex data #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, from a cursory glance. You're correct that we usually prefer not to scrape data from other sites, but in this case, pokedex numbers are so visible that the risk of them being inaccurate is probably pretty small. |
magical
reviewed
Jul 15, 2019
| 422,21,341 | ||
| 422,25,88 | ||
| 422E,16,260 | ||
| 422E,20,75 |
There was a problem hiding this comment.
These two rows are invalid. 422E should be 422.
There was a problem hiding this comment.
Thanks, somehow missed those.
| 423,21,342 | ||
| 423,25,89 | ||
| 423E,16,261 | ||
| 423E,20,76 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data courtesy of Bulbapedia.
Late edit: I understand the data in this repository shouldn't come from other fansites, but since I wanted the data anyway I opted to try to give back to this awesome dataset. I checked the edit history of the Pokedex page on Bulbapedia and it seems they never had to make a change, so I suspect they have a good source although I must admit I didn't check them all individually.