Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility between WTForms<=2.1 and SQLAlchemy>=1.2 #130

Open
magical opened this issue Jun 27, 2020 · 0 comments
Open

Incompatibility between WTForms<=2.1 and SQLAlchemy>=1.2 #130

magical opened this issue Jun 27, 2020 · 0 comments

Comments

@magical
Copy link
Member

magical commented Jun 27, 2020 •
edited
Loading

Older versions of WTForms are not compatible with SQLAlchemy 1.2 (wtforms/wtforms-sqlalchemy#9). We should probably declare a dependency on WTForms>=2.2.

But first we should make sure everything works correctly under WTForms 2.3 (the latest release).
magical added a commit that referenced this issue Jun 27, 2020
@magical
Pokémon search: escape pokedex labels
1c1ab44 
WTForms 2.3 started escaping label text with markupsafe[1].
We have several cases where we actually do want the label to contain
html (to show icons). In most cases we were already passing an object
with an __html__ method so nothing needs to be changed. The only
exception is the list of regional pokedexes on the pokemon search page.

[1]: wtforms/wtforms#315

Updates #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magical