Update conv_encode #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update own repository
List of changes: 1) code_type is deprecated and moved to the __init__ 2) termination parameter is added 3) new logical for 'cont' (Continuous) encoding is added 4) puncture_matrix=None the puncturing is not started -> avoid additional loop
|
I just took a look on the changes. I didn't go into detail because I don't know well this module but it would be nice to update the documentation at the same time. |
|
I've added puncturing and depunctured (inserting zeros) functions additionally. It may be useful for the turbo codes, I guess. |
|
@veeresht could you have a quick look at this PR ? I'm not familiar enough with the convolutional codes to review this. If it looks good to you I can update the doc for this one and then rebase my own PR on top of this one. |
|
Looks good! Thanks @kirlf 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: