Attempted fix for True Append code #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the True Append code created a temporary file in order to perform the pairwise "new vs. old" TN93 calculations. However, @stevenweaver reported the following:
This PR consists of 3 commits:
tempfile.NamedTemporaryFile
, it now usestempfile.mkdtemp
to create a temporary directory within which to create the named pipe, so it might still have the same issue as before (@stevenweaver please test it out to check)true_append
function and removes themain
function to reduce redundant codemain
was executed when the script was run from the command line, and thismain
function would (1) useargparse
to parse the user's command line arguments, and then (2) orchestrate the execution of the actual True Append functionshivtrace
repository, a new function calledtrue_append
was created as a modified copy ofmain
but which parses the relevant inputs via function arguments rather than command line argumentstrue_append
to parse the relevant True Append inputs via function arguments if they're provided, otherwise it will try to parse them from the command line, removing the need for a separatemain
functionchmod a+x
)