Add keyboard shortcuts #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domoritz Can you share few more useful keyboard shortcuts for the editor? |
domoritz
reviewed
Jun 6, 2018
| this.editorWillMount = this.editorWillMount.bind(this); | ||
| } | ||
| public handleKeydown(e) { | ||
| if (e.keyCode === KEYCODES.B && e.ctrlKey && !this.props.autoParse) { |
There was a problem hiding this comment.
On mac os, it's CMD+B. We should be agnostic to that. How do we do this best?
I think build is the most important one. We could override CMD+S to build as well. |
|
Visual feedback added. |
domoritz
requested changes
Jun 12, 2018
|
|
||
| .button:active, | ||
| .button-press { | ||
| box-shadow: 0 0 1px 0 #000; |
There was a problem hiding this comment.
box-shadow: 0 0 5px 1px steelblue;
| } | ||
|
|
||
| .button:active, | ||
| .button-press { |
| <button | ||
| id="parse-button" | ||
| className={this.props.parse ? 'button button-press' : 'button'} | ||
| onClick={() => this.props.parseSpec(true)} |
There was a problem hiding this comment.
can you make it so the button doesn't change when you click on it manually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add keyboard shortcuts
(Ctrl || CMD) && (B || S)for parsing.Fixes #100.