Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tick size responsive to plot height #9395

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jul 30, 2024

PR Description

Before:

Tick size doesn't respond to plot size change

image

after:

Now it does:

image

Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 228c9fe
Status: ✅  Deploy successful!
Preview URL: https://ad2bf697.vega-lite.pages.dev
Branch Preview URL: https://kw-7724-tick-size.vega-lite.pages.dev

View logs

@kanitw kanitw force-pushed the kw/7724-tick-size branch 2 times, most recently from c233434 to 87b4319 Compare July 30, 2024 01:27
@kanitw kanitw requested a review from lsh July 30, 2024 01:35
@kanitw kanitw marked this pull request as ready for review July 30, 2024 01:35
@kanitw kanitw requested a review from a team as a code owner July 30, 2024 01:35
@kanitw
Copy link
Member Author

kanitw commented Jul 30, 2024

need to fix these examples:

  • layer_bar_tick_datum_grouped
image
  • tick grouped
image

@kanitw kanitw merged commit 3f5dce6 into main Jul 30, 2024
8 of 9 checks passed
@kanitw kanitw deleted the kw/7724-tick-size branch July 30, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants