Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tooltip content for binned fields #29

Closed
light-and-salt opened this issue Apr 5, 2016 · 3 comments
Closed

Clean up tooltip content for binned fields #29

light-and-salt opened this issue Apr 5, 2016 · 3 comments
Assignees

Comments

@light-and-salt
Copy link
Contributor

Related issue: https://github.com/vega/vega-lite-ui/issues/167

@light-and-salt
Copy link
Contributor Author

Right now for binned fields tooltip shows: start, mid, end, and range. I also notice sometimes range can be empty.

When range is available, we should show field name and range. When range is not available, we should use start and end to compute a range for tooltip to display (?)

Case 1
bin1
Tooltip should show: Rotten_Tomatoes_Rating: 90-100, IMDB_Rating: 6-7

Case 2
bin2
Tooltip should show: Acceleration: 10-15

Case 3
bin3point
Tooltip should show: Acceleration: 15-20

@kanitw
Copy link
Member

kanitw commented Apr 8, 2016

Why dont you just read start and end and always produce one row that shows
range and make thhe label just say bin_x

People dont need 3-4 rows to understand one data field.

On Fri, Apr 8, 2016 at 10:09 AM Zening notifications@github.com wrote:

Right now for binned fields tooltip shows: start, mid, end, and range. I
also notice sometimes range can be empty.

When range is available, we should show field name and range. When range
is not available, we should use start and end to compute a range for
tooltip to display (?)

Case 1
[image: bin1]
https://cloud.githubusercontent.com/assets/822034/14391443/e35faab2-fd70-11e5-90b6-a72284ace44f.png
Tooltip should show: Rotten_Tomatoes_Rating: 90-100, IMDB_Rating: 6-7

Case 2
[image: bin2]
https://cloud.githubusercontent.com/assets/822034/14391479/08de74e4-fd71-11e5-8c97-3dffaca4e96a.png
Tooltip should show: Acceleration: 10-15

Case 3
[image: bin3point]
https://cloud.githubusercontent.com/assets/822034/14391497/1c5af394-fd71-11e5-8468-6fd06783b1cb.png
Tooltip should show: Acceleration: 15-20


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#29 (comment)

@light-and-salt light-and-salt changed the title Add an example with binned fields Clean up tooltip content for binned fields Apr 8, 2016
@light-and-salt
Copy link
Contributor Author

This is part of PR #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants