Add delay in tooltip #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
light-and-salt
force-pushed
the
zqu/delay
branch
from
9474c8a
to
53be0cd
Compare
light-and-salt
changed the title
|
|
||
| tooltipPromise = window.setTimeout(function() { | ||
| init(event, item, options); | ||
| tooltipActive = true; |
There was a problem hiding this comment.
why isn't this line a part of init?
There was a problem hiding this comment.
I didn’t put tooltipActive in init() or clear() because it’s only referenced by onmouseover, onmousemove, and onmouseout listeners, so putting it closer to the event listeners might be easier to read?
9 tasks
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| (function() { | |||
| // by default, delay showing tooltip for 100 ms | |||
| const DELAY = 100; | |||
There was a problem hiding this comment.
Yes you shouldn't use const in ES5.
light-and-salt
force-pushed
the
zqu/delay
branch
from
f0194a6
to
b42d1ab
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visibility:hiddeninstead ofdisplay:nonebecause we need to know the rendered tooltip height and width to place it in the right positionclear()onAppear,onDisappear,onMovecallbacks in examples to make sure that these callbacks are executed in the right moments given time delay. For example,onAppearcallback should be called when tooltip actually becomes visible.