-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
running tests after installation #181
Comments
No. The tests were removed. The tests are only available in the |
Now that there are reasonable ways to skip tests on CRAN and on various continuous integration services that we utilise, we could reconsider this and have tests (if appropriate) in the released version too. I'm not suggesting we switch to testthat or anything but we can borrow their ideas to implement the check for one or more environmental variables (for CRAN, Travis-CI, and Appveyor) and just throw an |
If you (or anybody) knows how to do this, and have the time and patience to implement the change, then we can keep tests in the CRAN release of vegan_2.4-0. The plan so far is to remove tests from the cran-2.4 branch as soon as we make the release and the master becomes 2.5-0. I just want to avoid the test mess in CRAN. |
I've only used it via testthat but I understand the general principle. I won't get chance to do this before the 2.4-0 release date though, but I will look to implement it in the master branch and then move the tests back to the 2.5-0 branch at some later point in time. Ideally the end result would be having no need to remove tests from a release branch. |
OK, thanks. Are the tests that were deleted when 2.3 was branched off still applicable t 2.3-5? |
The deleted tests may not be valid any longer. The tests have changed a lot in
The Most of these changes were not ported to the The pain of maintaining two parallel branches of tests is another reason of dropping them from the release branch. |
We are planning to release vegan 2.4-0 within a couple of days and hard working on 2.3-5 may not be rewarding. The plan is to remove tests from the CRAN branch, but the current tests apply for the future dash-zero release. |
OK, that sounds like a much better plan. Thanks. I'm pretty much through getting the package together minus tests, but I'll wait until 2.4 now. One thing you may not be aware of while going through the packaging process. |
We are aware of circular dependence between permute and vegan and we have solved the issue: the tests in permute are conditional on the availability of vegan (see This was discussed in gavinsimpson/permute#4 |
vegan 2.4-0 was released today and it is available on CRAN. We removed the tests again from the release version, but the 2.4-0 release is identical to the current master branch and the same tests can be used. |
Thanks for the heads up. I just pushed a vegan package to the master branch of Guix which reverts the test deletion patch. |
Hi,
I'm attempting to package vegan for GNU Guix. It seems all it all works, but to be more confident it would be good to run the test code, to see that it compiles correctly etc etc. I see that the tests are not included in the CRAN release, and the 2.3 branch has seen many commits and much time since the tests were deleted (I believe they were deleted in c67ae3d).
Is it possible to run tests on released code?
Thanks,
ben
The text was updated successfully, but these errors were encountered: