Issue #198: permutest(<dbrda-result>, first = TRUE) fails #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 20, 2016 12:04
suggested fix to github issue #198: permutest (and hence anova) failed when first=TRUE was requested
…ents cast to oldCapscale (with message) and use old non-distance-based analysis.
now we guarantee a symmetric input and tell eigen() that symmetric = TRUE, and permutest(<dbrda-object>, first=TRUE) is almost 2x faster.
Current coverage is 22.06% (diff: 60.00%)@@ master #199 diff @@
==========================================
Files 450 450
Lines 18451 18456 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4072 4072
- Misses 14379 14384 +5
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes following problems:
permutest(<dbrda-result>, first = TRUE)fails as reported in issue permutest of dbrda fails with first=TRUE #198. The comments to issue permutest of dbrda fails with first=TRUE #198 explain the reasons and fix in more detail. Commits 0f4cf0c and 346ea39capscaleuses only real dimensions in finding the eigenvalues, andfirst=TRUEcannot be analysed similarly as withdbrda. Commit daa34e6eigenwhen it tried to find out if the input matrix was symmetric. Now the input is guaranteed to be symmetric, and telling this toeigencan make the function to run almost 2x faster. Commit c76a1be