GH Actions CI Additions + Linter fixups #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two manual Github Actions workflows, and one automated workflow that runs both jobs on every PR commit. The workflows include: - Automated linting with golangci-lint - Automated `go test ./...` Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
|
Looks like the CircleCI pipeline is broken, and there's 3x suggestions from the golangci-lint run. I'll patch those shortly. |
| # When a new revision is pushed to a PR, cancel all in-progress CI runs for that | ||
| # PR. See https://docs.github.com/en/actions/using-jobs/using-concurrency | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} |
There was a problem hiding this comment.
Ooooo! Ok, this is super fancy! I'm stealing this for use at my day job. Thanks!
philipaconrad
force-pushed
the
gh-actions-ci
branch
2 times, most recently
from
50bfde4
to
ed0b70c
Compare
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
philipaconrad
force-pushed
the
gh-actions-ci
branch
from
ed0b70c
to
ffc8b42
Compare
|
Finally placated the linter. 😅 |
.github/workflows/pull-request.yml
Outdated
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Golang Style and Lint Check | ||
| run: docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.46.2 golangci-lint run -v |
There was a problem hiding this comment.
So I wonder why you are choosing to run the docker image, rather than the golangci-lint GitHub action from the marketplace? Does the docker version also annotate the PR with inline comments the way the action marketplace golangci-lint does?
There was a problem hiding this comment.
I'll admit, I just copied that part of the workflow over wholesale from OPA's pull-request workflow, and lifted up the underlying shell command for the make check target (the Docker command you saw). 😅
I'll try out the Github action, and see if that works equally well. The less fiddly commands in those workflows, the less stuff that can break.
There was a problem hiding this comment.
Looks like the Github actions version works okay. I pinned it to latest on the linter version.
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
|
@StevenACoffman Thank you for taking the time to triage this PR! 😄 Let me know if you'd like me to squash-rebase my commit chain for a cleaner merge commit. |
github-merge-queue bot
referenced
this pull request
in infratographer/x
Jul 14, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/vektah/gqlparser/v2](https://togithub.com/vektah/gqlparser) | require | patch | `v2.5.1` -> `v2.5.6` | --- ### Release Notes <details> <summary>vektah/gqlparser (github.com/vektah/gqlparser/v2)</summary> ### [`v2.5.6`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.6) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.5...v2.5.6) #### What's Changed - feat: support end of definition comment and end of file comment by [@​Warashi](https://togithub.com/Warashi) in [https://github.com/vektah/gqlparser/pull/264](https://togithub.com/vektah/gqlparser/pull/264) - feat(formatter): preserve spaces at the head of comments by [@​Warashi](https://togithub.com/Warashi) in [https://github.com/vektah/gqlparser/pull/265](https://togithub.com/vektah/gqlparser/pull/265) **Full Changelog**: vektah/gqlparser@v2.5.5...v2.5.6 ### [`v2.5.5`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.5) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.4...v2.5.5) #### What's Changed - feat: format with comments by [@​Warashi](https://togithub.com/Warashi) in [https://github.com/vektah/gqlparser/pull/263](https://togithub.com/vektah/gqlparser/pull/263) **Full Changelog**: vektah/gqlparser@v2.5.4...v2.5.5 ### [`v2.5.4`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.4) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.3...v2.5.4) #### What's Changed - feat(lexer): comment token support by [@​Warashi](https://togithub.com/Warashi) in [https://github.com/vektah/gqlparser/pull/261](https://togithub.com/vektah/gqlparser/pull/261) #### New Contributors - [@​Warashi](https://togithub.com/Warashi) made their first contribution in [https://github.com/vektah/gqlparser/pull/261](https://togithub.com/vektah/gqlparser/pull/261) **Full Changelog**: vektah/gqlparser@v2.5.3...v2.5.4 ### [`v2.5.3`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.3) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.2...v2.5.3) #### What's Changed - Update modules by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [https://github.com/vektah/gqlparser/pull/259](https://togithub.com/vektah/gqlparser/pull/259) **Full Changelog**: vektah/gqlparser@v2.5.2...v2.5.3 ### [`v2.5.2`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.2) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.1...v2.5.2) #### What's Changed - Add github actions to lint by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [https://github.com/vektah/gqlparser/pull/241](https://togithub.com/vektah/gqlparser/pull/241) - GH Actions CI Additions + Linter fixups by [@​philipaconrad](https://togithub.com/philipaconrad) in [https://github.com/vektah/gqlparser/pull/242](https://togithub.com/vektah/gqlparser/pull/242) - Prefer to wrap third party errors by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [https://github.com/vektah/gqlparser/pull/243](https://togithub.com/vektah/gqlparser/pull/243) - Remove a duplicate line in lexer_test.yml by [@​ryicoh](https://togithub.com/ryicoh) in [https://github.com/vektah/gqlparser/pull/244](https://togithub.com/vektah/gqlparser/pull/244) - Point to the right GraphQL spec by [@​Khyme](https://togithub.com/Khyme) in [https://github.com/vektah/gqlparser/pull/250](https://togithub.com/vektah/gqlparser/pull/250) - Bump json5 from 2.2.0 to 2.2.3 in /validator/imported by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vektah/gqlparser/pull/251](https://togithub.com/vektah/gqlparser/pull/251) - support [@​defer](https://togithub.com/defer) directive by [@​fiatjaf](https://togithub.com/fiatjaf) in [https://github.com/vektah/gqlparser/pull/255](https://togithub.com/vektah/gqlparser/pull/255) - Don't drop repeatable keyword when formatting directive by [@​tadeokondrak](https://togithub.com/tadeokondrak) in [https://github.com/vektah/gqlparser/pull/256](https://togithub.com/vektah/gqlparser/pull/256) - Validate directive arguments during schema parsing by [@​fredzqm](https://togithub.com/fredzqm) in [https://github.com/vektah/gqlparser/pull/258](https://togithub.com/vektah/gqlparser/pull/258) - Validate enum values directive are legit by [@​fredzqm](https://togithub.com/fredzqm) in [https://github.com/vektah/gqlparser/pull/257](https://togithub.com/vektah/gqlparser/pull/257) #### New Contributors - [@​ryicoh](https://togithub.com/ryicoh) made their first contribution in [https://github.com/vektah/gqlparser/pull/244](https://togithub.com/vektah/gqlparser/pull/244) - [@​Khyme](https://togithub.com/Khyme) made their first contribution in [https://github.com/vektah/gqlparser/pull/250](https://togithub.com/vektah/gqlparser/pull/250) - [@​fiatjaf](https://togithub.com/fiatjaf) made their first contribution in [https://github.com/vektah/gqlparser/pull/255](https://togithub.com/vektah/gqlparser/pull/255) - [@​tadeokondrak](https://togithub.com/tadeokondrak) made their first contribution in [https://github.com/vektah/gqlparser/pull/256](https://togithub.com/vektah/gqlparser/pull/256) - [@​fredzqm](https://togithub.com/fredzqm) made their first contribution in [https://github.com/vektah/gqlparser/pull/258](https://togithub.com/vektah/gqlparser/pull/258) **Full Changelog**: vektah/gqlparser@v2.5.1...v2.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/infratographer/x). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjE0MS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello gqlparser maintainers!
This PR includes:
Let me know if this PR needs additional improvements/revisions, and I'll cut out some time to make those modifications. 😄
Closes: #240