Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce node version on python #888

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Enforce node version on python #888

merged 1 commit into from
Mar 25, 2024

Conversation

ofhouse
Copy link
Member

@ofhouse ofhouse commented Mar 22, 2024

Description

We have to make sure that the Python examples stick to the 18.x runtime until Python is supported by the new build container.
See: https://vercel.com/docs/deployments/build-image

Demo URL

Type of Change

  • New Example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

New Example Checklist

  • 🛫 npm run new-example was used to create the example
  • 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • 📱 Is it responsive? Are mobile and tablets considered?

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-dir-css-in-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
app-dir-i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
app-dir-share-state ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
build-output-api-static-files ❌ Failed (Inspect) Mar 22, 2024 2:58pm
edge-ab-testing-google-optimize ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-ab-testing-statsig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-add-header ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-bot-protection-botd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-bot-protection-datadome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-cookies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-cors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-crypto ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-feature-flag-configcat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-feature-flag-posthog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-feature-flag-split ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-geolocation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-hostname-rewrites ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-image-response ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-ip-blocking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-ip-blocking-datadome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-json-response ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-jwt-authentication ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-news ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-power-parity-pricing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-power-parity-pricing-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-query-params-filter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-redirects-upstash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-functions-streams ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-geolocation-country-block ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-maintenance-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-middleware-modify-request-header ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-rewrites-upstash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
edge-user-agent-based-rendering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
example-auth-with-ory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
example-feature-flag-apple-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
example-reduce-image-bandwidth-usage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
feature-flag-hypertune ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
feature-flag-launchdarkly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
feature-flag-optimizely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
geolocation-script ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
next-edge-api-route-hello-world ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
nodejs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
redirects-bloom-filter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-combining-data-fetching-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-image-fallback ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-image-offset ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-loading-web-fonts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-microfrontends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-microfrontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-on-demand-isr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-pagination-with-ssg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-reuse-responses ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-script-component-ad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-script-component-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
solutions-subdomains-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
toolbar-launchdarkly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
toolbar-optimizely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
toolbar-split ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm
toolbar-statsig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 2:58pm

Copy link
Contributor

@janory janory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ofhouse ofhouse merged commit 020b9fc into main Mar 25, 2024
90 of 104 checks passed
@ofhouse ofhouse deleted the ofhouse/enfore-node-version branch March 25, 2024 09:50
janory added a commit that referenced this pull request May 6, 2024
Vinfall added a commit to Vinfall/rss2ics that referenced this pull request May 12, 2024
Sounds silly to have a `package.json`? See vercel/examples#888
trek added a commit that referenced this pull request Jul 1, 2024
Reverts #888

We [shipped](https://vercel.com/docs/deployments/build-image) support
for Python 3.12 in AL2023, these examples should work now with Node 20
as well.

Co-authored-by: Trek Glowacki <trek.glowacki@gmail.com>
newcharmingdev7 pushed a commit to newcharmingdev7/e-com that referenced this pull request Aug 10, 2024
Reverts vercel/examples#888

We [shipped](https://vercel.com/docs/deployments/build-image) support
for Python 3.12 in AL2023, these examples should work now with Node 20
as well.

Co-authored-by: Trek Glowacki <trek.glowacki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants