-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce node version on python #888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofhouse
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob and
lpalmes
as code owners
March 22, 2024 14:47
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
janory
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
EndangeredMassa
approved these changes
Mar 22, 2024
Vinfall
added a commit
to Vinfall/rss2ics
that referenced
this pull request
May 12, 2024
Sounds silly to have a `package.json`? See vercel/examples#888
trek
added a commit
that referenced
this pull request
Jul 1, 2024
Reverts #888 We [shipped](https://vercel.com/docs/deployments/build-image) support for Python 3.12 in AL2023, these examples should work now with Node 20 as well. Co-authored-by: Trek Glowacki <trek.glowacki@gmail.com>
newcharmingdev7
pushed a commit
to newcharmingdev7/e-com
that referenced
this pull request
Aug 10, 2024
Reverts vercel/examples#888 We [shipped](https://vercel.com/docs/deployments/build-image) support for Python 3.12 in AL2023, these examples should work now with Node 20 as well. Co-authored-by: Trek Glowacki <trek.glowacki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have to make sure that the Python examples stick to the
18.x
runtime until Python is supported by the new build container.See: https://vercel.com/docs/deployments/build-image
Demo URL
Type of Change
New Example Checklist
npm run new-example
was used to create the example