undefined in plugins array causes Hyper to refuse to open windows, with no visible errors whatsoever

[ELLIOTTCABLE]

• I am on the latest Hyper.app version

• I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: macOS Sierra 10.12.5 Beta (16F60a)

• Hyper.app version: Hyper ** 1.3.3.1754**

• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/ELLIOTTCABLE/678ad79704a104c8f29efcfaddd09e07

• The issue is reproducible in vanilla Hyper.app: Yes

Issue

Having accidentally commented out the first element of a comma-prefixed plugins array in .hyper.js,

   plugins: [
  //  'hypercwd'
    , 'hyperterm-alternatescroll'
    , 'hyperterm-focus-reporting'
      // ...
   ],

… I discovered that Hyper shows no errors, but refuses to open any windows.

Probably not a common mistake, or a huge problem, but I thought it'd be worth reporting. 😜

[ppot]

#1509

[nitsakh]

Hello, I would like to take up this issue. I haven't contributed to Hyper before. Would the #hyper channel on slack be a good place to get help?
For this issue, is the expected behaviour to ignore the comma and continue loading the other plugins?

[chabou]

Do not hesitate to ask on #hyper channel.
Yep, we must ignore undefined plugins. Maybe remove undefinedentries in plugin array after config parsing.

[albinekb]

😂 comma prefixed, nice 👌 My linter would catch that.

Yeah let's just do .filter(Boolean)

[albinekb]

Fixed in #1927

[ELLIOTTCABLE]

<'3

Thanks, @nitsakh! And welcome to open-source!