Addressing issue #1862 by filtering out Boolean values from the plugins list #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugins list in the config.
chabou
suggested changes
Jun 12, 2017
app/config/init.js
Outdated
| @@ -36,6 +36,8 @@ const _init = function (cfg) { | |||
| notify('Error reading configuration: `config` key is missing'); | |||
| return _extractDefault(cfg.defaultCfg); | |||
| } | |||
| // Ignore undefined values in plugin array Issue #1862 | |||
| _cfg.plugins = _cfg.plugins.filter(Boolean); | |||
There was a problem hiding this comment.
Could _cfg.plugins be undefined? If yes we should check it:
_cfg.plugins = (_cfg.plugins && _cfg.plugins.filter(Boolean)) || [];localPlugins should be filtered too
There was a problem hiding this comment.
Yes, that's right! Will add that. About localPlugins I was thinking that it is dev only, so thought it's not needed to run through that check each time unnecessary.
There was a problem hiding this comment.
If localPluginsis empty, it will do nothing. It is pretty useless you're right, but it is better for consistency imo.
chabou
approved these changes
Jun 12, 2017
albinekb
approved these changes
Jun 13, 2017
2 tasks
tylerong
pushed a commit
to tylerong/hyper
that referenced
this pull request
Jul 3, 2017
… plugins list (vercel#1927) * Addressing issue vercel#1862 by filtering out Boolean values from the plugins list in the config. * Updating the PR based on review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
.filter(Boolean)to filter out the undefined values in the config plugins array.