Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.4.0 changed hyperborder Theme #2135

Closed
2 tasks done
cytryn opened this issue Aug 30, 2017 · 4 comments
Closed
2 tasks done

Update to 1.4.0 changed hyperborder Theme #2135

cytryn opened this issue Aug 30, 2017 · 4 comments

Comments

@cytryn
Copy link

cytryn commented Aug 30, 2017

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • Mac OS X 10.12.6:

  • Hyper.app 1.4.0:

Issue

After the update the hyperborder theme now does not respect my background color. It used to be only colored border, now it colors the whole terminal

image

also, I can't type things like vim ~/.zshrc, it wont let me type ~. I know there are other issues about this but they are all fixed and closed, but it seems to have resurfaced again:

image

Is there something I missed in the update?

@leo
Copy link
Contributor

leo commented Aug 30, 2017

Have you considered that the plugin needs to be updated? 😊

@chabou
Copy link
Collaborator

chabou commented Aug 30, 2017

hyperborder plugin depends on hyper_main css class. But we only have _main class now 🤔
Certainly a regression.

Same for hyper_header hyper_terms etc..

@cytryn
Copy link
Author

cytryn commented Aug 30, 2017

@leo yeah, good point. I am pretty new to zsh+hyper so I am sorry about the noob question. Though that hyperborder was pretty basic and would not be affected by any update before being tweaked.

What about the ~ and other special characters like ' and "?

@leo
Copy link
Contributor

leo commented Aug 31, 2017

#2140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants