Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to write any composed characters #2140

Closed
2 tasks done
bukinoshita opened this issue Aug 30, 2017 · 18 comments
Closed
2 tasks done

Not able to write any composed characters #2140

bukinoshita opened this issue Aug 30, 2017 · 18 comments
Labels
‼️ Priority: OMG Maximum Issue needs to be seen to immediately. Like now. Please. ⚠️ 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@bukinoshita
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS Sierra 10.12.6
  • Hyper.app version: 1.4.1

Issue

Not able to write ' and ".
kapture 2017-08-30 at 16 53 55

@chabou
Copy link
Collaborator

chabou commented Aug 30, 2017

Can you try without any plugin ?

@bukinoshita
Copy link
Author

just tried, same result

@tleunen
Copy link

tleunen commented Aug 30, 2017

Same issue since the recent 1.4.x

I'm using the "US international - PC" keyboard on mac, and both the single quote and double quote are now failing to work properly.

This uses to work fine on 1.3.x.

This was the initial issue a long time ago #518

@cytryn
Copy link

cytryn commented Aug 31, 2017

+1 I have the same issue

@hampuslidin
Copy link

Can confirm this issue on my Swedish keyboard. Seems like all accent characters (~, ¨, ´, `, etc.), that is symbols requiring an additional keystroke to be written out, are subject to this.

@chabou chabou added ‼️ Priority: OMG Maximum Issue needs to be seen to immediately. Like now. Please. ⚠️ 🐛 Type: Bug Issue pertains to something wrong within Hyper labels Aug 31, 2017
@chabou
Copy link
Collaborator

chabou commented Aug 31, 2017

Reproduced with a french keyboard for symbols requiring an additional keystroke as mentioned by @lidin.
I've found a weird "workaround": hitting same character or click left with mouse (focusing seems to release catched char). But impossible to compose ñ for example 😞

@chabou
Copy link
Collaborator

chabou commented Aug 31, 2017

Regression was introduced by upgrading electron in this commit:
e09a7f7

@JoJordens
Copy link

Looks like this is the case with all dead keys. ~ ' " ^ etc

@leo leo changed the title Not able to write ' and " Not able to write any composed characters Aug 31, 2017
@albinekb
Copy link
Contributor

I can type ' and ", but have problem with key compositions like ` and ~ (on swedish keyboard)

it would be helpful if you added what keyboard layout you're using when you get the problem with " and ' as I cannot reproduce this.

@wellyal
Copy link

wellyal commented Aug 31, 2017

I was able to press ' and then space on the older version. But the newest one took that off from me. Hope this can be fixed soon. :'(

UPDATE: Seems like CMD + D does the trick.

@mdeboer
Copy link

mdeboer commented Aug 31, 2017

Same problem here, U.S. International - PC keyboard layout. Can't write ', " and ~. Seems like all characters that are composed with more than one key are bugged.

What's a terminal without ~? 😕

chabou added a commit to chabou/hyper that referenced this issue Sep 1, 2017
@leo leo closed this as completed in #2158 Sep 3, 2017
leo pushed a commit that referenced this issue Sep 3, 2017
@mdeboer
Copy link

mdeboer commented Sep 3, 2017

W00t @chabou you're a legend, can't wait to try this!

@chabou
Copy link
Collaborator

chabou commented Sep 3, 2017

Shipped in v1.4.3.
@mdeboer Please confirm that your issue is resolved

@bukinoshita
Copy link
Author

@chabou working just fine with me, thanks!

@leo
Copy link
Contributor

leo commented Sep 3, 2017

🎉

@wellyal
Copy link

wellyal commented Sep 4, 2017

@chabou you're a hero. thx!!!!

@albinekb
Copy link
Contributor

albinekb commented Sep 4, 2017

🎉

@mdeboer
Copy link

mdeboer commented Sep 4, 2017

@chabou I updated and tried today, it works perfectly for me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‼️ Priority: OMG Maximum Issue needs to be seen to immediately. Like now. Please. ⚠️ 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests

10 participants