-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set line-height same as font size #1841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could better to just remove this line. By default, line-height has the same value than font-size.
I don't know why we have this line-height of 1.2em
set.
We must be sure to not introduce some regressions
@chabou just removed whole css block for x-row, this should be fine |
@chabou @rauchg This was added by @dotcypress for emoji! |
set x-row to 1em
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM fixes #628
I think this is 👌 we can fix regressions. |
Set
x-row
line-height
same asfont-size
to fix issues with some fonts on last line of terminal.This PR should fix #628
UPDATE: removed whole css as chabou said line-height is same as font size as default