Ensure correct update channel is displayed in About window #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo
added
🐧 Platform: Linux
albinekb
approved these changes
Aug 30, 2017
| @@ -19,7 +19,11 @@ module.exports = (createWindow, updatePlugins, getLoadedPluginVersions) => { | |||
| const config = getConfig(); | |||
| const {commands} = getKeymaps(); | |||
|
|
|||
| const updateChannel = config.canaryUpdates ? 'canary' : 'stable'; | |||
| let updateChannel = 'stable'; | |||
There was a problem hiding this comment.
I think this logic should live inside the config, so that it's populated correctly whereever we need this? But OK for now
There was a problem hiding this comment.
We have different logics in those two places at the moment, but yep - definitely! 👍
chabou
added a commit
that referenced
this pull request
Sep 3, 2017
* master: (62 commits) 1.4.3 Disable ia32 linux releases (#2164) Fixed writing composed characters (#2158) Doc: Add yarn install to contribute instructions (#2117) Change "Close Session" shortcut on Linux/Windows (#2160) Notice for plugins (#2114) Updated dependencies to the latest version (#2146) 1.4.2 Reverted class names to as they were before (#2139) 1.4.1 AppVeyor environment variables are now on the platform (#2137) Brought back the icon for closing tabs (#2136) Brought back keymap documentation to the website (#2133) 1.4.0 Don't build on master, except for releases (#2132) Ensured that `async-retry` is added to the bundle (#2131) Ensure correct update channel is displayed in About window (#2130) Retry loading it if config doesn't exist in auto updater (#2129) Write contents of default config to hyper.js (#2128) Use a string for setting the update channel (#2127) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.