Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed "Close Session" shortcut so it doesn't have the same as "Quit" #2160

Merged
merged 1 commit into from
Sep 3, 2017
Merged

Changed "Close Session" shortcut so it doesn't have the same as "Quit" #2160

merged 1 commit into from
Sep 3, 2017

Conversation

louislva
Copy link
Contributor

@louislva louislva commented Sep 2, 2017

Fixed issue #2156

phfontess
phfontess suggested changes Sep 3, 2017
View reviewed changes
Copy link

@phfontess phfontess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only ctrl + tab it's nice to close tab.

@chabou
Copy link
Collaborator

chabou commented Sep 3, 2017

@phfontess ctrl+tab and ctrl+shift+tab will certainly be used to cycle between tabs like Chrome

@phfontess
Copy link

Oh I'm so sorry. I wanted to say only Ctrl + W, as it is used in version 1.3.3.

@louislva
Copy link
Contributor Author

louislva commented Sep 3, 2017

Ctrl+W for closing panes would be problematic as Ctrl is used as a character in most terminals including hyper. Lots of command line apps probably depend on Ctrl + W for their own shortcuts.

@chabou
Copy link
Collaborator

chabou commented Sep 3, 2017

ctrl+w is used to delete word before cursor in bash/zsh
And agree with @louislva ctrl+[a-z] should be reserved to shell and command line programs.

@chabou chabou merged commit 843ebd2 into vercel:master Sep 3, 2017
@chabou
Copy link
Collaborator

chabou commented Sep 3, 2017

Thank you so much @louislva

chabou added a commit that referenced this pull request Sep 3, 2017
@chabou
Merge branch 'master' into xterm
944f9d7 
* master: (62 commits)
  1.4.3
  Disable ia32 linux releases (#2164)
  Fixed writing composed characters (#2158)
  Doc: Add yarn install to contribute instructions (#2117)
  Change "Close Session" shortcut on Linux/Windows  (#2160)
  Notice for plugins (#2114)
  Updated dependencies to the latest version (#2146)
  1.4.2
  Reverted class names to as they were before (#2139)
  1.4.1
  AppVeyor environment variables are now on the platform (#2137)
  Brought back the icon for closing tabs (#2136)
  Brought back keymap documentation to the website (#2133)
  1.4.0
  Don't build on master, except for releases (#2132)
  Ensured that `async-retry` is added to the bundle (#2131)
  Ensure correct update channel is displayed in About window (#2130)
  Retry loading it if config doesn't exist in auto updater (#2129)
  Write contents of default config to hyper.js (#2128)
  Use a string for setting the update channel (#2127)
  ...
@louislva
Copy link
Contributor Author

louislva commented Sep 4, 2017

Thanks for letting me contribute! I've been wanting to get into OSS contributing for a while now, and the hyper community seems really friendly.

@chabou
Copy link
Collaborator

chabou commented Sep 4, 2017

You are really welcome and we are proud to have your first OSS contribution 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phfontess phfontess phfontess requested changes

@chabou chabou chabou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louislva @chabou @phfontess