-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change font size with command shortcuts #34
Conversation
|
This is brilliant. We should probably memorize the option @jhaynie. Perhaps |
@johanbrook yes, was thinking exactly that. But in order to make quick progress I'd like to use |
alert(e); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functions are almost identical. I would DRY them up into one that accepted an argument of whether to increment or decrement.
It should also support switch back to the default size |
i'll add the menu accelerators and DRY up the functions. I think we should memoize these in a separate PR to keep this one focused. |
OK, i added reset behavior and added window shortcuts and DRY up code. |
@jhaynie this is beyond beautiful and it works flawlessly. Only nit: we need to let the user know about the font change. Here's my suggestion (it's shown alongside the columns and rows since font changes trigger a resize) |
Another minor nit: from the perspective of Then we can capture it in |
I'm filing issues for these two things. |
Change the font size for the window with standard command + or -