-
Notifications
You must be signed in to change notification settings - Fork 319
Upgrade next-css: dependency update & added flag #581
Conversation
…ncludes support for ignoreOrder flag. According to mini-css-extract-plugin docs (which extract-css-chunks-webpack-plugin emulates), "for projects where css ordering has been mitigated through consistent use of scoping or naming conventions, the css order warnings can be disabled by setting the ignoreOrder flag to true for the plugin." Thus, it is safe to use the ignoreOrder flag where cssModules == true.
We're not planning to update next-css as vercel/next.js#8626 is close to landing on stable. |
@timneutkens I wasn't aware of that proposal- that's good to know, thanks. However, I don't see why this non-breaking PR couldn't be a stop-gap measure so that users are able to address current warnings while vercel/next.js#8626 is still being developed. |
+1 - this is a nonbreaking PR. It will take organizations significant time to adopt vercel/next.js#8626, whereas this update could be had quickly. Please merge and release... it's canary anyway. |
+1 agreed, it's annoying. Also agree on merging this now, faster to fix. |
You can't guarantee it won't break hence why I'm not keen on releasing it to around 50% of Next.js users vs a solution that will be guaranteed to not break + not have the css ordering issue, which is vercel/next.js#8626. There still are CSS ordering issues with cssModules in this package. |
@timneutkens Unless I'm misunderstanding the documentation and there's someway to use 9.2 built-in-css support with css modules and a css preprocessor, this is still relevant. Correct me if I'm wrong? |
Built-in css support has both css modules and postcss support: https://nextjs.org/docs/basic-features/built-in-css-support#adding-component-level-css For postcss you can add SCSS/SASS support will be added very soon. Less/stylus won't be included as usage is very low. |
@timneutkens currently using |
Hey! We're deprecating this repository hence why this PR hasn't been merged. I just updated the readme. Thanks for your contribution! |
Upgrade
extract-css-chunks-webpack-plugin
to latest version, which includes support forignoreOrder
flag. According tomini-css-extract-plugin
docs (whichextract-css-chunks-webpack-plugin
emulates):Thus, it is safe to use the
ignoreOrder
flag wherecssModules == true
.Addresses Issue #569
EDIT formatting