Repository navigation
Fixing: Unable to delete dlp-id on old Webkit, used in PS4
#94646
Replies: 6 comments
|
Have you tried building with a browserslist that targets that version of Safari? I reckon, there might be other issues just waiting to happen, because our support is for 16.4+ - IIRC, someone reported another issue in Safari 15, w/ 16.2.x too |
|
hi, maybe ... |
|
Do you mind if we move this to a discussion then? and Update the title. You have made a PR, not sure what'll happen to that, but for now we can use discussions to give visibility to your proposed patch. |
|
I dont mind at all. Wasn't sure about the right process. |
|
and for the PR I can close it, no problem. It's just one line |
|
I think you can leave the PR open for now. Just that, given our supported browser policy, and issue is not fit here. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Start a next application after 16.2.0 in a Safari 9 which is used in Playstation 4.
The application will error with this message
TypeError: Unable to delete propertyCurrent vs. Expected behavior
The expectation is that the application run on an old webkit browser.
Provide environment information
Solution
We narrow down the problem to this line, in
packages/next/src/shared/lib/deployment-id.ts:It seems to be related of how webkit implemented dataset, as discussed in this thread
It was confirmed by a local patch that we deployed
This single changes enable us to use next@16.2.6 on old playstation 4.
The same fix was applied in this fork
It's a very niche edge case but as the fix involved just using a different method with no regression, we thought it would worse creating an issue with a fix
PR with patch: #94604
All reactions