Repository navigation
Replies: 1 comment 1 reply
|
actually do we even need the lru if |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Goals
Non-Goals
Background
Between 16.1 and 16.2 the image-optimizer changed to add in LRU
by default (w/o a cachehandler, maximumDiskCacheSize as undefined, and isrFlushDisk as true) this runs and we really do enjoy local disk caches for assets.
it wants to initCacheEntries
and readFromCacheDir
unfortunately this requires every file in the cache directory to open to get a size
we have a unique setup, where the cache directory is externalized (via symlink) so that directory gets quite BIG, via nfs.
our first image load time takes more than 5 minutes for the to open
Proposal
determine if
sizeis even needed for the LRUif it is change to
readFromCacheDir(cacheDir, cacheKey, skipBuffer)have that return a size which could be based on
[ secondary proposal, next config option to disable the Eager start lru option but still have isDiskCacheEnabled ]
All reactions