Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-intl example #1022

Closed
sedubois opened this issue Feb 7, 2017 · 5 comments
Closed

React-intl example #1022

sedubois opened this issue Feb 7, 2017 · 5 comments

Comments

@sedubois
Copy link
Contributor

sedubois commented Feb 7, 2017

I saw some people wondering how to get react-intl working with Next.js, and so far it worked well in my app: https://github.com/relatenow/relate

So maybe it could be used as inspiration to create an example in the examples folder.

@sedubois
Copy link
Contributor Author

sedubois commented Feb 7, 2017

Also see @ericf's WIP example which does a better job of loading only the active locale client-side: formatjs/formatjs#844

@ericf
Copy link
Contributor

ericf commented Feb 9, 2017

I completed the example. This is my first time really digging into Next, so it would be great to get a review here: formatjs/formatjs#844

Also I'm happy to move this example app to this repo. Or if we decide to leave it in React Intl's repo, it would be nice to add least add an examples/react-intl/README.md entry here.

@timneutkens
Copy link
Member

@ericf looks good! I'd love to have this in the next.js repo 👍🏻👍🏻

ericf added a commit to ericf/next.js that referenced this issue Feb 9, 2017
@ericf
Copy link
Contributor

ericf commented Feb 9, 2017

@timneutkens @sedubois I opened PR #1055 to add it here.

timneutkens pushed a commit that referenced this issue Feb 24, 2017
* Add example app with React Intl

Fixes #1022

* Update examples/with-react-intl/package.json to be consistent
@julkue
Copy link

julkue commented Feb 2, 2018

The example is broken: #3386 (comment)

@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants