Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/with-three-js): Upgrade drei@2.2.21 & three@0.125.0 #22365 #22431

Merged
merged 2 commits into from
Feb 22, 2021
Merged

fix(examples/with-three-js): Upgrade drei@2.2.21 & three@0.125.0 #22365 #22431

merged 2 commits into from
Feb 22, 2021

Conversation

getspooky
Copy link
Contributor

If the three dependency is upgraded to version 0.125.0 and upwards, the following errors occur:

  • Compilation error: Attempted import error: 'Geometry' is not exported from 'three'.
  • ReferenceError: Blob is not defined.

Solution:
Upgrade drei to 2.2.21.

@ijjk ijjk added the examples Issue/PR related to examples label Feb 22, 2021
@getspooky getspooky mentioned this pull request Feb 22, 2021
Closed
leerob
leerob approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit 4b587d3 into vercel:canary Feb 22, 2021
This was referenced Mar 5, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
This was referenced Mar 8, 2021
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@getspooky @leerob @ijjk