-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use react as peer dependency #997
Comments
👍 Actually, this is something I wanted to do from the first release. |
I like this 👍 Only downside would be that you'd have to |
@timneutkens I think that's totally fine. But we need to update a lot of examples :) |
- tackles vercel#997 - add ./idea to gitignore for webstorm users - update all the examples
- tackles vercel#997 - add ./idea to gitignore for webstorm users - update all the examples
@eezing yep |
@arunoda, @nkzawa Sorry. . . deleted my previous comment by mistake. You confirmed that There's something very appealing about a single dependency: |
@eezing We used to have the idea of "default React" which would be used if you didn't explicitly install React on your app. We can discuss that or any other possibilities. |
- tackles #997 - add ./idea to gitignore for webstorm users - update all the examples
Ref: https://twitter.com/finneganswoke/status/828060921918529536
I think it's a pretty good idea to let the app to give us
react
andreact-dom
.2.0 is a best place to do this, since this is a breaking change.
What do you guys think? @nkzawa @rauchg
The text was updated successfully, but these errors were encountered: