Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react as peer dependency #997

Closed
arunoda opened this issue Feb 5, 2017 · 6 comments
Closed

Use react as peer dependency #997

arunoda opened this issue Feb 5, 2017 · 6 comments
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@arunoda
Copy link
Contributor

arunoda commented Feb 5, 2017

Ref: https://twitter.com/finneganswoke/status/828060921918529536

I think it's a pretty good idea to let the app to give us react and react-dom.
2.0 is a best place to do this, since this is a breaking change.

What do you guys think? @nkzawa @rauchg

@nkzawa
Copy link
Contributor

nkzawa commented Feb 5, 2017

👍 Actually, this is something I wanted to do from the first release.

@timneutkens
Copy link
Member

I like this 👍 Only downside would be that you'd have to npm install --save next react react-dom but that's ok 😄

@arunoda
Copy link
Contributor Author

arunoda commented Feb 6, 2017

@timneutkens I think that's totally fine. But we need to update a lot of examples :)

@arunoda arunoda added the good first issue Easy to fix issues, good for newcomers label Feb 6, 2017
sakulstra added a commit to sakulstra/next.js that referenced this issue Feb 7, 2017
- tackles vercel#997
- add ./idea to gitignore for webstorm users
- update all the examples
sakulstra added a commit to sakulstra/next.js that referenced this issue Feb 7, 2017
- tackles vercel#997
- add ./idea to gitignore for webstorm users
- update all the examples
@nkzawa
Copy link
Contributor

nkzawa commented Feb 8, 2017

@eezing yep

@eezing
Copy link

eezing commented Feb 8, 2017

@arunoda, @nkzawa Sorry. . . deleted my previous comment by mistake. You confirmed that $ npm install next react react-dom are required for $ node_modules/.bin/next to run.

There's something very appealing about a single dependency: next. It's a breath of fresh air if you ask me. Considering Next is a framework, it seems totally reasonable to keep react & react-dom as a hard dependency by default.

@nkzawa
Copy link
Contributor

nkzawa commented Feb 8, 2017

@eezing We used to have the idea of "default React" which would be used if you didn't explicitly install React on your app. We can discuss that or any other possibilities.

arunoda pushed a commit that referenced this issue Feb 8, 2017
- tackles #997
- add ./idea to gitignore for webstorm users
- update all the examples
@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants