Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render styled-jsx in _document example #1287

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Render styled-jsx in _document example #1287

merged 1 commit into from
Feb 27, 2017

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 26, 2017 •
edited
Loading

Fixes #1236

The reason we have to do this is that when provided _document will override our Document class. _document will extend our Document class. But given that we override getInitialProps in _document we have to copy over its contents, including styled-jsx. Otherwise they are not server-rendered which will cause the FOUC mentioned in #1236.

@timneutkens timneutkens mentioned this pull request Feb 26, 2017
Closed
@timneutkens timneutkens added this to the 2.0 milestone Feb 26, 2017
@arunoda
Copy link
Contributor

arunoda commented Feb 27, 2017

Pretty good point.

@arunoda arunoda merged commit e1babdf into vercel:master Feb 27, 2017
@timneutkens timneutkens deleted the 1236 branch February 28, 2017 05:05
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @arunoda @timweprovide