fix(NODE_ENV): Warn when launching start or build on development

[moh12594]

The PR aims to fix #14022

[lachlanjc]

This could use a quick review!

[ijjk]

Failing test suites

Commit: 765605d

test/integration/non-standard-node-env-warning/test/index.test.js

• Non-Standard NODE_ENV > should show the warning with NODE_ENV set to production with dev command

Expand output

● Non-Standard NODE_ENV › should show the warning with NODE_ENV set to production with dev command

expect(received).toContain(expected) // indexOf

Expected substring: "You are using a non-standard \"NODE_ENV\" value in your environment"
Received string:    "ready - started server on 0.0.0.0:42125, url: http://localhost:42125
info  - Using locally built binary of @next/swc
event - compiled client and server successfully in 1110 ms (158 modules)
"

  118 |     expect(output).toContain(warningText)
  119 |   })
> 120 |
      | ^
  121 |   it('should show the warning with NODE_ENV set to invalid value (custom server)', async () => {
  122 |     let output = ''
  123 |

  at Object.<anonymous> (integration/non-standard-node-env-warning/test/index.test.js:120:24)

[timneutkens]

It's good to land now, a bunch of tests were missing so I've added those.

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
buildDuration	17.8s	18s	⚠️ +197ms
buildDurationCached	3.3s	3.3s	-12ms
nodeModulesSize	347 MB	347 MB	⚠️ +886 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.97	2.921	-0.05
/ avg req/sec	841.73	855.89	+14.16
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.35	1.382	⚠️ +0.03
/error-in-render avg req/sec	1852.07	1809.04	⚠️ -43.03

Client Bundles (main, webpack, commons)

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.49 kB	4.49 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
buildDuration	19.2s	19.1s	-131ms
buildDurationCached	3.3s	3.3s	-27ms
nodeModulesSize	347 MB	347 MB	⚠️ +886 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.896	2.924	⚠️ +0.03
/ avg req/sec	863.4	855.05	⚠️ -8.35
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.362	1.346	-0.02
/error-in-render avg req/sec	1835.74	1857.38	+21.64

Client Bundles (main, webpack, commons)

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.53 kB	4.53 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.9 kB	1.9 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	moh12594/next.js fix/issue-14022	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 30f738e