Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release hook to format the changelog by labels #14592

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Add release hook to format the changelog by labels #14592

merged 7 commits into from
Jul 28, 2020

Conversation

rafaelalmeidatk
Copy link
Contributor

@rafaelalmeidatk rafaelalmeidatk commented Jun 26, 2020 •
edited
Loading

This should already work without vercel/release#173
edit: Now with the change to a CLI flag, this has to be merged only after the above PR

One thing to keep in mind is the fact that since the requests to GH aren't authenticated, there is a limit of 60 requests/hour. I tested and it might be better to send the GH connection that release already has to the hook, so the rate limit is way higher

@ijjk
Copy link
Member

ijjk commented Jun 26, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
buildDuration 11s 10.8s -228ms
nodeModulesSize 67.1 MB 67.1 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.868 1.788 -0.08
/ avg req/sec 1338.46 1398.33 ⚠️ +59.87
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.123 1.129 ⚠️ +0.01
/error-in-render avg req/sec 2226.46 2214.56 -11.9
Client Bundles (main, webpack, commons)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.module.js gzip 5.59 kB 5.59 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
index.html gzip 952 B 952 B ✓
link.html gzip 957 B 957 B ✓
withRouter.html gzip 944 B 944 B ✓
Overall change 2.85 kB 2.85 kB ✓
Serverless Mode
General
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
buildDuration 12s 12.2s ⚠️ +144ms
nodeModulesSize 67.1 MB 67.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.module.js gzip 5.59 kB 5.59 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: f7cea07

rafaelalmeidatk
rafaelalmeidatk commented Jun 27, 2020
View reviewed changes
package.json
@@ -29,7 +29,7 @@
"types": "lerna run types --stream",
"typescript": "lerna run typescript",
"prepublish": "lerna run prepublish",
"publish-canary": "lerna version prerelease --preid canary --force-publish && release --pre",
"publish-canary": "lerna version prerelease --preid canary --force-publish && release --pre --skip-questions",
Copy link
Contributor Author

@rafaelalmeidatk rafaelalmeidatk Jun 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to be changed somewhere else too for stable releases?

@ijjk
Copy link
Member

ijjk commented Jun 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
buildDuration 12.5s 12.5s ⚠️ +5ms
nodeModulesSize 67.1 MB 67.1 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.371 2.377 ⚠️ +0.01
/ avg req/sec 1054.59 1051.54 -3.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.409 1.491 ⚠️ +0.08
/error-in-render avg req/sec 1773.91 1676.54 -97.37
Client Bundles (main, webpack, commons)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.module.js gzip 5.59 kB 5.59 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
index.html gzip 954 B 954 B ✓
link.html gzip 959 B 959 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
buildDuration 13.5s 13.2s -326ms
nodeModulesSize 67.1 MB 67.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.module.js gzip 5.59 kB 5.59 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: 72eda2b

@ijjk
Copy link
Member

ijjk commented Jun 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
buildDuration 13s 12.8s -153ms
nodeModulesSize 67.1 MB 67.1 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.205 2.172 -0.03
/ avg req/sec 1133.62 1150.75 ⚠️ +17.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.465 1.513 ⚠️ +0.05
/error-in-render avg req/sec 1706.86 1652.29 -54.57
Client Bundles (main, webpack, commons)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.module.js gzip 5.59 kB 5.59 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
index.html gzip 954 B 954 B ✓
link.html gzip 959 B 959 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
buildDuration 13.8s 13.6s -204ms
nodeModulesSize 67.1 MB 67.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
main-HASH.module.js gzip 5.59 kB 5.59 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary rafaelalmeidatk/next.js release-config Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: be8aa48

@timneutkens timneutkens merged commit c50843f into vercel:canary Jul 28, 2020
@timneutkens timneutkens mentioned this pull request Jul 28, 2020
Merged
LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020
@rafaelalmeidatk @timneutkens @LauraBeatris
Add release hook to format the changelog by labels (vercel#14592)
f9f28cd 
* Add release hook

* Remove release.js exported config

* Add skip flag to release CLI

* Use full flag name

* Upgrade release

* Update yarn.lock

Co-authored-by: Tim Neutkens <timneutkens@me.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelalmeidatk @ijjk @timneutkens