Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cssnano-simple dependency #15488

Merged
merged 7 commits into from
Jul 27, 2020
Merged

Upgrade cssnano-simple dependency #15488

merged 7 commits into from
Jul 27, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Jul 26, 2020 •
edited
Loading

Fixes #15468 and adds regression tests

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jul 26, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
buildDuration 11.5s 11.2s -328ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +160 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.822 1.871 ⚠️ +0.05
/ avg req/sec 1372.23 1336.41 ⚠️ -35.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.126 1.104 -0.02
/error-in-render avg req/sec 2219.83 2264.83 +45
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
buildDuration 12.5s 12.6s ⚠️ +133ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +160 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 922 kB 922 kB ✓
routerDirect.js 916 kB 916 kB ✓
withRouter.js 916 kB 916 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: 109a560

@Timer Timer marked this pull request as ready for review July 26, 2020 18:42
@ijjk
Copy link
Member

ijjk commented Jul 26, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
buildDuration 12.3s 11.9s -349ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +160 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.977 1.986 ⚠️ +0.01
/ avg req/sec 1264.48 1259.06 ⚠️ -5.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.236 1.212 -0.02
/error-in-render avg req/sec 2022.55 2062.59 +40.04
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
buildDuration 13.3s 13.5s ⚠️ +278ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +160 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/upgrade-cssnano-simple Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 922 kB 922 kB ✓
routerDirect.js 916 kB 916 kB ✓
withRouter.js 916 kB 916 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: 1d6a6be

@Timer
Copy link
Member Author

Timer commented Jul 27, 2020

Landing this as it is very important for the next stable release.

@Timer Timer merged commit e837c22 into vercel:canary Jul 27, 2020
@Timer Timer deleted the hotfix/upgrade-cssnano-simple branch July 27, 2020 03:56
timneutkens
timneutkens reviewed Jul 27, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine 👍

LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020
@Timer @LauraBeatris
Upgrade cssnano-simple dependency (vercel#15488)
a43cade
@kachkaev kachkaev mentioned this pull request May 1, 2021
Merged
1 task
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[canary] CSS ordering changed sometime after canary.21
3 participants
@Timer @ijjk @timneutkens