Add next/image default loader errors #18152

ijjk · 2020-10-22T23:56:12Z

This adds checks to the next/image component when the default loader is used to help surface errors in the dev overlay in development. Currently it checks for missing src and width values and also checks that the src has a valid hostname if non-relative

x-ref: #18122

…r-errors

…r-errors # Conflicts: # packages/next/client/image.tsx

ijjk · 2020-10-23T21:21:56Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	14.1s	14s	-65ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +2.86 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.723	2.791	⚠️ +0.07
/ avg req/sec	918.12	895.75	⚠️ -22.37
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.573	1.576	0
/error-in-render avg req/sec	1589.19	1585.88	⚠️ -3.31

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-af76201..828d.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-3ba933e..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	16.3s	16.4s	⚠️ +117ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +2.86 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-af76201..828d.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-3ba933e..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: fdebf77

test/integration/image-component/default/pages/invalid-src.js

test/integration/image-component/default/pages/missing-src.js

packages/next/client/image.tsx

…r-errors

ijjk · 2020-10-24T17:51:39Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	13s	13.4s	⚠️ +346ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +3.51 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.411	2.431	⚠️ +0.02
/ avg req/sec	1036.71	1028.31	⚠️ -8.4
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.4	1.362	-0.04
/error-in-render avg req/sec	1785.84	1835	+49.16

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-af76201..828d.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-3ba933e..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	14.9s	14.6s	-276ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +3.51 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-af76201..828d.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-3ba933e..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: 8873107

ijjk · 2020-10-25T04:53:00Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	12.1s	11.9s	-148ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +3.51 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.424	2.308	-0.12
/ avg req/sec	1031.48	1083.31	+51.83
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.536	1.47	-0.07
/error-in-render avg req/sec	1627.47	1700.83	+73.36

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3dd37a4..54de.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-082aff9..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	994 B	994 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	14s	14s	⚠️ +37ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +3.51 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3dd37a4..54de.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-082aff9..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: af5204b

ijjk · 2020-10-25T05:04:06Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	11.2s	11.2s	⚠️ +6ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +3.51 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.16	2.206	⚠️ +0.05
/ avg req/sec	1157.41	1133.51	⚠️ -23.9
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.338	1.329	-0.01
/error-in-render avg req/sec	1868.02	1881.81	+13.79

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3dd37a4..54de.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-082aff9..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	994 B	994 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
buildDuration	12.8s	13s	⚠️ +142ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +3.51 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3dd37a4..54de.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-082aff9..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js img/default-loader-errors	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: cdcc460

ijjk added 2 commits October 22, 2020 18:51

Add next/image default loader errors

b1c9b2f

Merge remote-tracking branch 'upstream/canary' into img/default-loade…

ad89451

…r-errors

ijjk added the type: next label Oct 22, 2020

This comment has been minimized.

Sign in to view

ijjk added 2 commits October 23, 2020 16:00

Merge remote-tracking branch 'upstream/canary' into img/default-loade…

129d6f5

…r-errors # Conflicts: # packages/next/client/image.tsx

Add domains check

fdebf77

ijjk mentioned this pull request Oct 23, 2020

[WIP] Next.js Image Component #18122

Closed

24 tasks

ijjk marked this pull request as ready for review October 23, 2020 21:14

ijjk requested review from lfades, Timer and timneutkens as code owners October 23, 2020 21:14

ijjk requested a review from styfle October 23, 2020 21:15

styfle reviewed Oct 23, 2020

View reviewed changes

test/integration/image-component/default/pages/invalid-src.js Outdated Show resolved Hide resolved

styfle reviewed Oct 23, 2020

View reviewed changes

test/integration/image-component/default/pages/missing-src.js Outdated Show resolved Hide resolved

styfle reviewed Oct 23, 2020

View reviewed changes

test/integration/image-component/default/pages/missing-src.js Outdated Show resolved Hide resolved

styfle reviewed Oct 23, 2020

View reviewed changes

packages/next/client/image.tsx Outdated Show resolved Hide resolved

styfle reviewed Oct 23, 2020

View reviewed changes

packages/next/client/image.tsx Outdated Show resolved Hide resolved

styfle reviewed Oct 23, 2020

View reviewed changes

packages/next/client/image.tsx Outdated Show resolved Hide resolved

ijjk added 2 commits October 23, 2020 20:41

Merge remote-tracking branch 'upstream/canary' into img/default-loade…

86f5c13

…r-errors

Apply suggestions from PR

4a9ccaa

ijjk requested a review from styfle October 24, 2020 01:46

This comment has been minimized.

Sign in to view

ijjk added 2 commits October 24, 2020 12:27

Merge remote-tracking branch 'upstream/canary' into img/default-loade…

738019f

…r-errors

Update test

8873107

styfle approved these changes Oct 24, 2020

View reviewed changes

Merge branch 'canary' into img/default-loader-errors

af5204b

Merge branch 'canary' into img/default-loader-errors

cdcc460

ijjk merged commit 9c65c99 into vercel:canary Oct 25, 2020

ijjk deleted the img/default-loader-errors branch October 25, 2020 05:22

timneutkens added the hacktoberfest-accepted label Nov 1, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add next/image default loader errors #18152

Add next/image default loader errors #18152

ijjk commented Oct 22, 2020 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 23, 2020

This comment has been minimized.

ijjk commented Oct 24, 2020

ijjk commented Oct 25, 2020

ijjk commented Oct 25, 2020

Add next/image default loader errors #18152

Add next/image default loader errors #18152

Conversation

ijjk commented Oct 22, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 23, 2020

Stats from current PR

This comment has been minimized.

ijjk commented Oct 24, 2020

Stats from current PR

ijjk commented Oct 25, 2020

Stats from current PR

ijjk commented Oct 25, 2020

Stats from current PR

ijjk commented Oct 22, 2020 •

edited

Loading