Remove aliases that are no longer needed #19937

timneutkens · 2020-12-07T19:27:58Z

Fixes #19939

…alias-config

…xt.js into fix/webpack5-alias-config

ijjk · 2020-12-07T19:41:35Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
buildDuration	10.1s	10.2s	⚠️ +59ms
nodeModulesSize	82.5 MB	82.5 MB	-1.25 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.416	2.487	⚠️ +0.07
/ avg req/sec	1034.96	1005.41	⚠️ -29.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.31	1.526	⚠️ +0.22
/error-in-render avg req/sec	1908.38	1637.74	⚠️ -270.64

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f501b4a..c42e.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	303 B	⚠️ +19 B
withRouter-7..c13d.js gzip	284 B	302 B	⚠️ +18 B
Overall change	8.27 kB	8.31 kB	⚠️ +37 B

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	607 B	-1 B
Overall change	1.84 kB	1.84 kB	-1 B

Diffs

Diff for _buildManifest.js

@@ -9,10 +9,10 @@ self.__BUILD_MANIFEST = {
   ],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-00f0f71a76f57326f2aa.js"],
   "/routerDirect": [
-    "static\u002Fchunks\u002Fpages\u002FrouterDirect-2e9bfd441bd88cd3382e.js"
+    "static\u002Fchunks\u002Fpages\u002FrouterDirect-6f408582ce776dfa74d5.js"
   ],
   "/withRouter": [
-    "static\u002Fchunks\u002Fpages\u002FwithRouter-9af1d72bd996729e701e.js"
+    "static\u002Fchunks\u002Fpages\u002FwithRouter-2cdddce06c9626f1dcfa.js"
   ],
   sortedPages: [
     "\u002F",

Diff for routerDirect..88cd3382e.js

@@ -1,6 +1,12 @@
 _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
   [9],
   {
+    /***/ "20a2": /***/ function(module, exports, __webpack_require__) {
+      module.exports = __webpack_require__("nOHt");
+
+      /***/
+    },
+
     /***/ LtRI: /***/ function(module, exports, __webpack_require__) {
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/routerDirect",
@@ -26,7 +32,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         react__WEBPACK_IMPORTED_MODULE_0__
       );
       /* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(
-        "nOHt"
+        "20a2"
       );
       /* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1___default = /*#__PURE__*/ __webpack_require__.n(
         next_router__WEBPACK_IMPORTED_MODULE_1__

Diff for withRouter-9..6729e701e.js

@@ -15,7 +15,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         react__WEBPACK_IMPORTED_MODULE_0__
       );
       /* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(
-        "nOHt"
+        "20a2"
       );
       /* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1___default = /*#__PURE__*/ __webpack_require__.n(
         next_router__WEBPACK_IMPORTED_MODULE_1__
@@ -38,6 +38,12 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /***/
     },
 
+    /***/ "20a2": /***/ function(module, exports, __webpack_require__) {
+      module.exports = __webpack_require__("nOHt");
+
+      /***/
+    },
+
     /***/ eThv: /***/ function(module, exports, __webpack_require__) {
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/withRouter",

Diff for withRouter.html

@@ -32,7 +32,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/pages/withRouter-9af1d72bd996729e701e.js"
+      href="/_next/static/chunks/pages/withRouter-2cdddce06c9626f1dcfa.js"
       as="script"
     />
   </head>
@@ -73,7 +73,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/withRouter-9af1d72bd996729e701e.js"
+      src="/_next/static/chunks/pages/withRouter-2cdddce06c9626f1dcfa.js"
       async=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
buildDuration	12.3s	11.8s	-511ms
nodeModulesSize	82.5 MB	82.5 MB	-1.25 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f501b4a..c42e.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	N/A	N/A
withRouter-7..c13d.js gzip	284 B	N/A	N/A
routerDirect..fd29.js gzip	N/A	303 B	N/A
withRouter-b..76ae.js gzip	N/A	302 B	N/A
Overall change	8.27 kB	8.31 kB	⚠️ +37 B

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-alias-config	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	⚠️ +129 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +129 B
Overall change	5.16 MB	5.16 MB	⚠️ +258 B

Commit: 519663b

Remove alias config that is no longer needed

f0a1a8d

timneutkens requested review from ijjk, lfades and Timer as code owners December 7, 2020 19:27

ijjk added the type: next label Dec 7, 2020

vercel bot temporarily deployed to Preview December 7, 2020 19:28 Inactive

timneutkens mentioned this pull request Dec 7, 2020

fix: webpack 5 invalid config error #19815

Closed

timneutkens and others added 2 commits December 7, 2020 20:31

Remove aliases that are no longer needed

02c49f9

Merge branch 'canary' into fix/webpack5-alias-config

0e5f812

vercel bot temporarily deployed to Preview December 7, 2020 19:31 Inactive

timneutkens added 2 commits December 7, 2020 20:32

Merge branch 'canary' of github.com:vercel/next.js into fix/webpack5-…

bc8c90c

…alias-config

Merge branch 'fix/webpack5-alias-config' of github.com:timneutkens/ne…

519663b

…xt.js into fix/webpack5-alias-config

vercel bot temporarily deployed to Preview December 7, 2020 19:32 Inactive

Timer approved these changes Dec 7, 2020

View reviewed changes

kodiakhq bot merged commit 4bca939 into vercel:canary Dec 7, 2020

timneutkens deleted the fix/webpack5-alias-config branch December 8, 2020 09:14

janicklas-ralph mentioned this pull request Feb 17, 2021

Experimental script loader changes #22038

Merged

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove aliases that are no longer needed #19937

Remove aliases that are no longer needed #19937

timneutkens commented Dec 7, 2020 •

edited

Loading

ijjk commented Dec 7, 2020

Diffs

Remove aliases that are no longer needed #19937

Remove aliases that are no longer needed #19937

Conversation

timneutkens commented Dec 7, 2020 • edited Loading

ijjk commented Dec 7, 2020

Stats from current PR

Diffs

timneutkens commented Dec 7, 2020 •

edited

Loading