Move productionBrowserSourceMaps out of experimental #20267

timneutkens · 2020-12-17T14:23:30Z

Makes https://www.npmjs.com/package/@zeit/next-source-maps a built-in feature so that it can be deprecated.

ijjk · 2020-12-17T14:33:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
buildDuration	11.5s	11.1s	-362ms
nodeModulesSize	82.4 MB	82.4 MB	-41 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.748	2.703	-0.05
/ avg req/sec	909.87	925	+15.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.698	1.625	-0.07
/error-in-render avg req/sec	1472.55	1538.65	+66.1

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-086d1b7..8537.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
buildDuration	13.2s	13.3s	⚠️ +157ms
nodeModulesSize	82.4 MB	82.4 MB	-41 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-086d1b7..8537.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: a89fa8e

ijjk · 2020-12-17T14:40:24Z

Failing test suites

Commit: a89fa8e

test/integration/production-browser-sourcemaps/test/index.test.js

Production browser sourcemaps > Server support > includes sourcemaps for all browser files
Production browser sourcemaps > Serverless support > includes sourcemaps for all browser files

Expand output

● Production browser sourcemaps › Server support › includes sourcemaps for all browser files

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  22 | 
  23 |     jsFiles.forEach((file) => {
> 24 |       expect(browserFiles.includes(`${file}.map`)).toBe(true)
     |                                                    ^
  25 |     })
  26 |   })
  27 | }

  at forEach (integration/production-browser-sourcemaps/test/index.test.js:24:52)
      at Array.forEach (<anonymous>)
  at Object.<anonymous> (integration/production-browser-sourcemaps/test/index.test.js:23:13)

● Production browser sourcemaps › Serverless support › includes sourcemaps for all browser files

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  22 | 
  23 |     jsFiles.forEach((file) => {
> 24 |       expect(browserFiles.includes(`${file}.map`)).toBe(true)
     |                                                    ^
  25 |     })
  26 |   })
  27 | }

  at forEach (integration/production-browser-sourcemaps/test/index.test.js:24:52)
      at Array.forEach (<anonymous>)
  at Object.<anonymous> (integration/production-browser-sourcemaps/test/index.test.js:23:13)

ijjk · 2020-12-17T14:53:48Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
buildDuration	11.6s	11.3s	-328ms
nodeModulesSize	82.4 MB	82.4 MB	-41 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.614	2.571	-0.04
/ avg req/sec	956.46	972.21	+15.75
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.685	1.473	-0.21
/error-in-render avg req/sec	1483.3	1697.75	+214.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-086d1b7..8537.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
buildDuration	13.6s	14s	⚠️ +316ms
nodeModulesSize	82.4 MB	82.4 MB	-41 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-086d1b7..8537.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/enable-production-browser-sourcemaps	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 7b4055d

docs/advanced-features/source-maps.md

timneutkens added 2 commits December 17, 2020 15:10

Move productionBrowserSourceMaps out of experimental

0cdd07a

Add sourcemaps doc

a89fa8e

timneutkens requested review from chibicode, ijjk, lfades and Timer as code owners December 17, 2020 14:23

ijjk added type: documentation type: next labels Dec 17, 2020

vercel bot temporarily deployed to Preview December 17, 2020 14:23 Inactive

Update tests

7b4055d

vercel bot temporarily deployed to Preview December 17, 2020 14:43 Inactive

Timer approved these changes Dec 17, 2020

View reviewed changes

timneutkens mentioned this pull request Dec 17, 2020

docs: add link webpack devtool vercel/next-plugins#675

Closed

kodiakhq bot merged commit 72fae8b into vercel:canary Dec 17, 2020

vitorhsb reviewed Dec 17, 2020

View reviewed changes

docs/advanced-features/source-maps.md Show resolved Hide resolved

kachkaev mentioned this pull request Dec 26, 2020

Production source maps show webpack-generated files rather than source files in 10.0.4 #20500

Closed

timneutkens deleted the add/enable-production-browser-sourcemaps branch February 12, 2021 13:33

KonnorRogers mentioned this pull request Mar 20, 2021

chore: update nextjs honeybadger-io/nextjs-with-honeybadger#4

Merged

This was referenced May 26, 2021

[Snyk] Security upgrade @next/bundle-analyzer from 9.5.5 to 10.0.4 majacQ/next.js#115

Open

[Snyk] Security upgrade @next/bundle-analyzer from 9.5.5 to 10.0.4 baby636/next.js#46

Open

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move productionBrowserSourceMaps out of experimental #20267

Move productionBrowserSourceMaps out of experimental #20267

timneutkens commented Dec 17, 2020

ijjk commented Dec 17, 2020

ijjk commented Dec 17, 2020

ijjk commented Dec 17, 2020

Move productionBrowserSourceMaps out of experimental #20267

Move productionBrowserSourceMaps out of experimental #20267

Conversation

timneutkens commented Dec 17, 2020

ijjk commented Dec 17, 2020

Stats from current PR

ijjk commented Dec 17, 2020

Failing test suites

ijjk commented Dec 17, 2020

Stats from current PR