Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update experimental profiling #20357

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Update experimental profiling #20357

merged 4 commits into from
Dec 21, 2020

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Dec 21, 2020 •
edited
Loading

Adds profiling for terser and css-minimizer. Will move the old profiler to this new system as well.

@vercel vercel bot temporarily deployed to Preview December 21, 2020 12:54 Inactive
@vercel vercel bot temporarily deployed to Preview December 21, 2020 13:31 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 21, 2020

Failing test suites

Commit: 4877f7b

test/integration/dist-dir/test/index.test.js

  • distDir > should handle null/undefined distDir
Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 675

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

@vercel vercel bot temporarily deployed to Preview December 21, 2020 14:09 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
buildDuration 9.1s 10s ⚠️ +860ms
nodeModulesSize 82.4 MB 82.6 MB ⚠️ +230 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.098 2.219 ⚠️ +0.12
/ avg req/sec 1191.47 1126.5 ⚠️ -64.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.158 1.11 -0.05
/error-in-render avg req/sec 2158.75 2252.25 +93.5
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
buildDuration 10.7s 10.7s -28ms
nodeModulesSize 82.4 MB 82.6 MB ⚠️ +230 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: b3264c2

@vercel vercel bot temporarily deployed to Preview December 21, 2020 14:49 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
buildDuration 10.9s 10.8s -38ms
nodeModulesSize 82.4 MB 82.6 MB ⚠️ +227 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.536 2.655 ⚠️ +0.12
/ avg req/sec 985.93 941.62 ⚠️ -44.31
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.289 1.408 ⚠️ +0.12
/error-in-render avg req/sec 1938.89 1775.22 ⚠️ -163.67
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
buildDuration 12.9s 13.2s ⚠️ +281ms
nodeModulesSize 82.4 MB 82.6 MB ⚠️ +227 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/opentelemetry-tracing Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: bfb6c66

@kodiakhq kodiakhq bot merged commit a9f1975 into vercel:canary Dec 21, 2020
@timneutkens timneutkens mentioned this pull request Dec 22, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Dec 29, 2020
@timneutkens
Add profiling to webpack loaders (#20392)
5c5108f 
Follow-up to #20357 with additional tracers.
@timneutkens timneutkens deleted the add/opentelemetry-tracing branch February 12, 2021 13:33
This was referenced May 26, 2021
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @Timer