Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update webpack to 5.33 #24077

Merged
merged 1 commit into from
Apr 14, 2021
Merged

update webpack to 5.33 #24077

merged 1 commit into from
Apr 14, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 14, 2021 •
edited

relevant changes:

@ijjk
Copy link
Member

ijjk commented Apr 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.33 Change
buildDuration 14.8s 14.7s -43ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +33.8 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/5.33 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.677 2.645 -0.03
/ avg req/sec 934.01 945.14 +11.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.522 1.564 ⚠️ +0.04
/error-in-render avg req/sec 1642.3 1598 ⚠️ -44.3
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.33 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.33 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.33 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.33 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.33 Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.33 Change
buildDuration 18.7s 18.5s -151ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +33.8 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.33 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.33 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.33 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.33 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.33 Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +2 B
link.js 1.45 MB 1.45 MB -3 B
routerDirect.js 1.44 MB 1.44 MB -2 B
withRouter.js 1.44 MB 1.44 MB -2 B
Overall change 7.14 MB 7.14 MB -5 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.33 Change
buildDuration 14.9s 14.8s -64ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +33.8 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.33 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.668 2.616 -0.05
/ avg req/sec 937.01 955.77 +18.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.488 1.475 -0.01
/error-in-render avg req/sec 1680.48 1694.72 +14.24
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.33 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.33 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.33 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.33 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.33 Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "C53KVAvfrs9KfUL4K5s1Q",
+        "buildId": "zJESklG7ReTkYZbJ8hoyU",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/C53KVAvfrs9KfUL4K5s1Q/_buildManifest.js"
+      src="/_next/static/zJESklG7ReTkYZbJ8hoyU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/C53KVAvfrs9KfUL4K5s1Q/_ssgManifest.js"
+      src="/_next/static/zJESklG7ReTkYZbJ8hoyU/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "C53KVAvfrs9KfUL4K5s1Q",
+        "buildId": "zJESklG7ReTkYZbJ8hoyU",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/C53KVAvfrs9KfUL4K5s1Q/_buildManifest.js"
+      src="/_next/static/zJESklG7ReTkYZbJ8hoyU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/C53KVAvfrs9KfUL4K5s1Q/_ssgManifest.js"
+      src="/_next/static/zJESklG7ReTkYZbJ8hoyU/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "C53KVAvfrs9KfUL4K5s1Q",
+        "buildId": "zJESklG7ReTkYZbJ8hoyU",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/C53KVAvfrs9KfUL4K5s1Q/_buildManifest.js"
+      src="/_next/static/zJESklG7ReTkYZbJ8hoyU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/C53KVAvfrs9KfUL4K5s1Q/_ssgManifest.js"
+      src="/_next/static/zJESklG7ReTkYZbJ8hoyU/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 034a93e

@kodiakhq kodiakhq bot merged commit 1e20730 into canary Apr 14, 2021
@kodiakhq kodiakhq bot deleted the webpack/5.33 branch April 14, 2021 21:23
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@sokra @SokratisVidros
update webpack to 5.33 (vercel#24077)
d0dc6b0 
relevant changes:

* performance improvements for `export *` and reexports
* fixes incorrect cache invalidation when new properties are added to the DefinePlugin (fixes vercel#23901)
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack 5 cache issue with NEXT_PUBLIC_ environment variables
2 participants
@sokra @ijjk