Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable strictExportPresence when webpack 5 is enabled #24214

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Disable strictExportPresence when webpack 5 is enabled #24214

merged 1 commit into from
Apr 19, 2021

Conversation

timneutkens
Copy link
Member

Solves an issue some users ran into where enabling webpack 5 highlighted a wrong JSON import where named exports were used for JSON data.

Should not import the named export 'myValue' (imported as 'myValue') from default-exporting module (only default export is available soon)

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@timneutkens
Disable strictExportPresence when webpack 5 is enabled
c286658 
Solves an issue some users ran into where enabling webpack 5 highlighted a wrong JSON import where named exports were used for JSON data.

> Should not import the named export 'myValue' (imported as 'myValue') from default-exporting module (only default export is available soon)
@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
buildDuration 13.3s 13.5s ⚠️ +247ms
buildDurationCached 4.2s 4.1s -84ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +288 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.409 2.349 -0.06
/ avg req/sec 1037.77 1064.11 +26.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.211 1.295 ⚠️ +0.08
/error-in-render avg req/sec 2064.31 1930.54 ⚠️ -133.77
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
buildDuration 17.3s 17.3s ⚠️ +28ms
buildDurationCached 6.3s 6.2s -113ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +288 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
buildDuration 11.7s 11.2s -584ms
buildDurationCached 4.6s 4.6s -44ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +288 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.34 2.332 -0.01
/ avg req/sec 1068.45 1072.06 +3.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.22 1.176 -0.04
/error-in-render avg req/sec 2048.55 2125.83 +77.28
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/json-import-error Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: c286658

Timer
Timer reviewed Apr 19, 2021
View reviewed changes
packages/next/build/webpack/config/blocks/base.ts
config.module.strictExportPresence = true

// TODO: add codemod for "Should not import the named export" with JSON files
config.module.strictExportPresence = !isWebpack5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a future rule that re-enables this behavior.

Extra nice would be to only disable this when webpack 5 is automatically enabled, but leaving the field enabled if the user explicitly turned on webpack 5.

@timneutkens timneutkens merged commit aee453e into vercel:canary Apr 19, 2021
@timneutkens timneutkens deleted the fix/json-import-error branch April 19, 2021 16:50
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@timneutkens @SokratisVidros
Disable strictExportPresence when webpack 5 is enabled (vercel#24214)
f729789 
Solves an issue some users ran into where enabling webpack 5 highlighted a wrong JSON import where named exports were used for JSON data.

> Should not import the named export 'myValue' (imported as 'myValue') from default-exporting module (only default export is available soon)
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer left review comments

@sokra sokra sokra approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timneutkens @ijjk @Timer @sokra