-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable strictExportPresence when webpack 5 is enabled #24214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves an issue some users ran into where enabling webpack 5 highlighted a wrong JSON import where named exports were used for JSON data. > Should not import the named export 'myValue' (imported as 'myValue') from default-exporting module (only default export is available soon)
timneutkens
requested review from
divmain,
ijjk,
lfades and
shuding
as code owners
April 19, 2021 10:22
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
buildDuration | 13.3s | 13.5s | |
buildDurationCached | 4.2s | 4.1s | -84ms |
nodeModulesSize | 46.3 MB | 46.3 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.409 | 2.349 | -0.06 |
/ avg req/sec | 1037.77 | 1064.11 | +26.34 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.211 | 1.295 | |
/error-in-render avg req/sec | 2064.31 | 1930.54 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
597-HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-HASH.js gzip | 7.08 kB | 7.08 kB | ✓ |
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-HASH.js gzip | 3.68 kB | 3.68 kB | ✓ |
amp-HASH.js gzip | 558 B | 558 B | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 243 B | 243 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 336 B | 336 B | ✓ |
withRouter-HASH.js gzip | 334 B | 334 B | ✓ |
Overall change | 9.03 kB | 9.03 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
_buildManifest.js gzip | 349 B | 349 B | ✓ |
Overall change | 349 B | 349 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
index.html gzip | 609 B | 609 B | ✓ |
link.html gzip | 614 B | 614 B | ✓ |
withRouter.html gzip | 604 B | 604 B | ✓ |
Overall change | 1.83 kB | 1.83 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
buildDuration | 17.3s | 17.3s | |
buildDurationCached | 6.3s | 6.2s | -113ms |
nodeModulesSize | 46.3 MB | 46.3 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
597-HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-HASH.js gzip | 7.08 kB | 7.08 kB | ✓ |
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-HASH.js gzip | 3.68 kB | 3.68 kB | ✓ |
amp-HASH.js gzip | 558 B | 558 B | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 243 B | 243 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 336 B | 336 B | ✓ |
withRouter-HASH.js gzip | 334 B | 334 B | ✓ |
Overall change | 9.03 kB | 9.03 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
_buildManifest.js gzip | 349 B | 349 B | ✓ |
Overall change | 349 B | 349 B | ✓ |
Serverless bundles
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
_error.js | 1.39 MB | 1.39 MB | ✓ |
404.html | 2.76 kB | 2.76 kB | ✓ |
500.html | 2.75 kB | 2.75 kB | ✓ |
amp.amp.html | 10.7 kB | 10.7 kB | ✓ |
amp.html | 1.96 kB | 1.96 kB | ✓ |
hooks.html | 2.01 kB | 2.01 kB | ✓ |
index.js | 1.39 MB | 1.39 MB | ✓ |
link.js | 1.45 MB | 1.45 MB | ✓ |
routerDirect.js | 1.44 MB | 1.44 MB | ✓ |
withRouter.js | 1.44 MB | 1.44 MB | ✓ |
Overall change | 7.15 MB | 7.15 MB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
buildDuration | 11.7s | 11.2s | -584ms |
buildDurationCached | 4.6s | 4.6s | -44ms |
nodeModulesSize | 46.3 MB | 46.3 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.34 | 2.332 | -0.01 |
/ avg req/sec | 1068.45 | 1072.06 | +3.61 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.22 | 1.176 | -0.04 |
/error-in-render avg req/sec | 2048.55 | 2125.83 | +77.28 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
677f882d2ed8..HASH.js gzip | 13.4 kB | 13.4 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 7.16 kB | 7.16 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 60.2 kB | 60.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-HASH.js gzip | 3.71 kB | 3.71 kB | ✓ |
amp-HASH.js gzip | 536 B | 536 B | ✓ |
hooks-HASH.js gzip | 888 B | 888 B | ✓ |
index-HASH.js gzip | 227 B | 227 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.89 kB | 8.89 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
_buildManifest.js gzip | 371 B | 371 B | ✓ |
Overall change | 371 B | 371 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/json-import-error | Change | |
---|---|---|---|
index.html gzip | 613 B | 613 B | ✓ |
link.html gzip | 619 B | 619 B | ✓ |
withRouter.html gzip | 607 B | 607 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
sokra
approved these changes
Apr 19, 2021
Timer
reviewed
Apr 19, 2021
config.module.strictExportPresence = true | ||
|
||
// TODO: add codemod for "Should not import the named export" with JSON files | ||
config.module.strictExportPresence = !isWebpack5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have a future rule that re-enables this behavior.
Extra nice would be to only disable this when webpack 5 is automatically enabled, but leaving the field enabled if the user explicitly turned on webpack 5.
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 20, 2021
Solves an issue some users ran into where enabling webpack 5 highlighted a wrong JSON import where named exports were used for JSON data. > Should not import the named export 'myValue' (imported as 'myValue') from default-exporting module (only default export is available soon)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves an issue some users ran into where enabling webpack 5 highlighted a wrong JSON import where named exports were used for JSON data.
Bug
fixes #number
Feature
fixes #number
Documentation / Examples