Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade postcss #24546

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Upgrade postcss #24546

merged 3 commits into from
Apr 28, 2021

Conversation

timneutkens
Copy link
Member

Fixes #24421

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Can't add an integration test currently, we'll add Node 16 tests later.

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Apr 28, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
buildDuration 14.4s 14.1s -262ms
buildDurationCached 4.7s 4.4s -338ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +1.21 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.505 2.549 ⚠️ +0.04
/ avg req/sec 997.99 980.61 ⚠️ -17.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.446 1.418 -0.03
/error-in-render avg req/sec 1729.49 1763.18 +33.69
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
index.html gzip 611 B 611 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
buildDuration 17.5s 17.4s -127ms
buildDurationCached 6.6s 6.6s ⚠️ +27ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +1.21 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +2 B
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ⚠️ +2 B
Overall change 7.14 MB 7.14 MB ⚠️ +4 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
buildDuration 12.3s 13s ⚠️ +652ms
buildDurationCached 5.1s 4.9s -203ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +1.21 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.593 2.725 ⚠️ +0.13
/ avg req/sec 964.26 917.4 ⚠️ -46.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.48 1.724 ⚠️ +0.24
/error-in-render avg req/sec 1689.69 1449.97 ⚠️ -239.72
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 2fd55fb

shuding
shuding previously approved these changes Apr 28, 2021
View reviewed changes
theoludwig
theoludwig previously approved these changes Apr 28, 2021
View reviewed changes
@ijjk ijjk dismissed stale reviews from theoludwig and shuding via 7f7df6d April 28, 2021 12:47
@ijjk
Copy link
Member

ijjk commented Apr 28, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
buildDuration 15.8s 16s ⚠️ +257ms
buildDurationCached 5.2s 4.8s -394ms
nodeModulesSize 46.7 MB 46.7 MB -4.62 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.758 2.822 ⚠️ +0.06
/ avg req/sec 906.5 885.85 ⚠️ -20.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.714 1.647 -0.07
/error-in-render avg req/sec 1458.57 1518.05 +59.48
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
index.html gzip 611 B 611 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
buildDuration 19.6s 19.2s -415ms
buildDurationCached 7.1s 7.2s ⚠️ +4ms
nodeModulesSize 46.7 MB 46.7 MB -4.62 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ⚠️ +4 B
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ⚠️ +4 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
buildDuration 13.5s 13.6s ⚠️ +86ms
buildDurationCached 5.7s 5.4s -333ms
nodeModulesSize 46.7 MB 46.7 MB -4.62 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.816 2.813 0
/ avg req/sec 887.76 888.74 +0.98
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.709 1.613 -0.1
/error-in-render avg req/sec 1462.91 1549.93 +87.02
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-postcss Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 7f7df6d

@kodiakhq kodiakhq bot merged commit b26077b into vercel:canary Apr 28, 2021
@ghost ghost mentioned this pull request Apr 28, 2021
Closed
This was referenced Apr 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
This was referenced Apr 28, 2021
Open
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@theoludwig theoludwig theoludwig left review comments

@shuding shuding shuding left review comments

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

next/image on node 16 give SIGSEGV
4 participants
@timneutkens @ijjk @shuding @theoludwig