Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade with-reasonml-todo to with-rescript-todo example #24899

Closed

Conversation

ryyppy
Copy link

@ryyppy ryyppy commented May 7, 2021

Follow up to #24898

ReasonML & BuckleScript have officially rebranded to ReScript, so I'd like to deprecate with-reasonml-todo in favour of a with-rescript-todo example.

I updated all the dependencies and converted the original example to ReScript / React.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@balazsorban44
Copy link
Member

Hi @ryyppy, there seem to be merge conflicts here, do you have the intention to bring this PR up-to-date? If not, let's close it for now. Thanks either way! 🙏 💚

@leerob
Copy link
Member

leerob commented Jan 4, 2023

Closing as stale – if you would like to continue this, please open a new PR and we can take a look. Thank you so much! 🙏

@leerob leerob closed this Jan 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants