Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preload test for safari #26020

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Update preload test for safari #26020

merged 1 commit into from
Jun 11, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 11, 2021

This fixes a failing test in the production suite on safari from the preload count being out of date. This also ensures we run browser specific tests with concurrency 1 since browserstack is limited to one run at a time currently

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member Author

ijjk commented Jun 11, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
buildDuration 14.2s 14.1s -43ms
buildDurationCached 3.4s 3.4s -25ms
nodeModulesSize 46.5 MB 46.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.877 2.957 ⚠️ +0.08
/ avg req/sec 868.95 845.39 ⚠️ -23.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.878 1.731 -0.15
/error-in-render avg req/sec 1331 1444.08 +113.08
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
index.html gzip 573 B 573 B ✓
link.html gzip 580 B 580 B ✓
withRouter.html gzip 568 B 568 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
buildDuration 16s 16.1s ⚠️ +68ms
buildDurationCached 4.6s 4.7s ⚠️ +75ms
nodeModulesSize 46.5 MB 46.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ⚠️ +2 B
withRouter.js 17.4 kB 17.4 kB -4 B
Overall change 107 kB 107 kB -2 B
Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
buildDuration 12.3s 12.4s ⚠️ +35ms
buildDurationCached 5s 4.9s -48ms
nodeModulesSize 46.5 MB 46.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.88 2.924 ⚠️ +0.04
/ avg req/sec 868.02 855.03 ⚠️ -12.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.685 1.655 -0.03
/error-in-render avg req/sec 1483.42 1510.73 +27.31
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.85 kB 3.85 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/safari-prefetch-test Change
index.html gzip 626 B 626 B ✓
link.html gzip 633 B 633 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: e9020ff

@ijjk ijjk merged commit 713e92e into vercel:canary Jun 11, 2021
@ijjk ijjk deleted the fix/safari-prefetch-test branch June 11, 2021 20:28
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@ijjk
Update preload test for safari (vercel#26020)
dbbe15b
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @styfle